?
avatar wilsonge
wilsonge
30 May 2020

Steps to reproduce the issue

In mysql we check for columns changed with the CHANGE syntax. we don't have an equivalent in postgres which leads to skipped checks.

Expected result

PostgreSQL db schema checker validates columns where the names are changed

Actual result

It doesn't

System information (as much as possible)

Postgres

Additional comments

None

avatar wilsonge wilsonge - open - 30 May 2020
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 30 May 2020
avatar richard67
richard67 - comment - 30 May 2020

In addition, it doesn't check on both kinds of databases for

  • DROP TABLE - that's why for the finder schema updates currently no errors are shown ;-)
  • ALTER TABLE .. RENAME ... (renaming tables)

I plan to work on that.

avatar richard67
richard67 - comment - 31 May 2020

Seems I‘ve made a mistake when checking this for @wilsonge : The schema checker for PostgreSQL DOES support column type changes, only the syntax is different to the (erroneous and meanwhile corrected) syntax in one of the recently corrected update SQL scripts.

But the other issues I‘ve mentioned in my previous comment are still valid.

@wilsonge Just change title and description of this one? Or close it because the other issues are expected behavior?

avatar wilsonge
wilsonge - comment - 1 Jun 2020

So the change column does work already (after the fixes we did on Saturday). It’s just deleting and renaming tables now?

avatar richard67
richard67 - comment - 1 Jun 2020

@wilsonge Correct. But if we add support fopr "DROP TABLE" (tables are dropped, not deleted) we might have the same problem with Hannes' update SQL as we had whe we developed the utf8mb4 conversion and tried to drop and then add back an index with the same name, like Hannes does with a table in the update sql for the finder. It would need either make the schema checker more clever for this, or change the sql so the table is modified in the right way instead of drop and create again.

I suggest we close this issue.

avatar richard67
richard67 - comment - 1 Jun 2020

@wilsonge For table rename I'm already working on a solution.

avatar wilsonge wilsonge - change - 1 Jun 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-06-01 10:09:18
Closed_By wilsonge
avatar wilsonge wilsonge - close - 1 Jun 2020

Add a Comment

Login with GitHub to post a comment