Feeling Lucky
?
?
?
[#29270] - [4.0] Prevent global timezone changing after use of JDate class
- Fixed in Code Base
- 7 Jun 2020
- Medium
- Build: 4.0-dev
- # 29270
- Diff
- Fedik:jdate-tz-fix2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #14587
Summary of Changes
As described in #14587 JDate incorrectly resets the TZ if the server default time zone not UTC.
In some reason JDate resets TZ to the server default instead of "previous state".
This patch fixing this strange behavior.
Testing Instructions
In the root index.php add
date_default_timezone_set('Europe/Berlin'); // emulate server time zone Europe/Berlinin template index.php add:
date_default_timezone_set('UTC');
var_dump(date_default_timezone_get());
$someDate = JDate::getInstance('now -3 day');
var_dump(date_default_timezone_get());Expected result
var dump should show:
'UTC'
'UTC' // correct
Actual result
'UTC'
'Europe/Berlin' // incorect
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
bonzani
- comment
- 2 Jun 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29270.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 2 Jun 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29270.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-07 13:15:40 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
?
|
||
wilsonge
- comment
- 7 Jun 2020
Thanks!
I have tested this item✅ successfully on 2d5ab45
1. Code review: Good.
2. Real test as described: Good.
3. As a guy who deals with time series and timezone conversions since some 20 years I can say this change is needed since long time.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29270.