Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#2927] - [CODE STYLE] Corrected Arguments with default values must be at the end ...

? Success

User tests: Successful: Unsuccessful:

avatar gunjanpatel
gunjanpatel
29 Jan 2014

...of the argument list

avatar gunjanpatel gunjanpatel - open - 29 Jan 2014
avatar Bakual
Bakual - comment - 29 Jan 2014

This changes code as it makes $idtag optional which is likely not what we want.
To fix it one can either reorder the arguments which would break BC, or we can make $optKey and $optText requiried and add the default values back in the code with something like

if (!$optKey)
{
  $optKey = 'value';
}

But then we loose the info about default values in IDEs.

So there is probably not a simple fix for this.

avatar gunjanpatel
gunjanpatel - comment - 29 Jan 2014

Yeah, getting you. We will have to rearrange argument and will need to change application of this function everywhere where it is using this argument.
Thanks for the info. Closing this PR.

avatar gunjanpatel gunjanpatel - change - 29 Jan 2014
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-01-29 12:37:23
Labels Added: ?
avatar gunjanpatel gunjanpatel - close - 29 Jan 2014
avatar gunjanpatel gunjanpatel - close - 29 Jan 2014
avatar gunjanpatel gunjanpatel - head_ref_deleted - 29 Jan 2014
avatar phproberto
phproberto - comment - 29 Jan 2014

Sorry @gunjanpatel we are still discussing which is the best approach to solve this and the other occurrences of the same CS error.

We will notify you the final decision.

Thanks for trying to fix it!

avatar gunjanpatel
gunjanpatel - comment - 30 Jan 2014

Great!
Thank you.

Add a Comment

Login with GitHub to post a comment