[#29263] - [4.0] [Workflow] Implement the whole permission system for the workflow
- Fixed in Code Base
- 13 Jun 2020
- Medium
- Build: 4.0-dev
- # 29263
- Diff
- bembelimen:wf/permissions
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
In the first step, the permissions of changing the workflow were very soft, so with this PR the permission checks are harden.
See:
Testing Instructions
Create 2 accounts:
- a full Super User account to change permissions (account 1)
- a "normal" backend account to test (account 2)
Now set up the com_content permissions with account 1, that account 2 can access workflow or not (+ test). Then activate/deactivate all permissions one by one (create, edit, delete) and test the workflow elements, if the set permission takes action.
After that go into the individual elements and test the permissions there, too.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries |
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
| Category | Administration Language & Strings Libraries | ⇒ | Administration com_content com_workflow Language & Strings Modules Libraries |
@bembelimen please fix cs https://ci.joomla.org/joomla/joomla-cms/32784/1/9
It's already fixed locally, just don't want to push every minute some updates, so I collect and push every few hours.
Edit a transition.
Undefined index: workflow_id in \administrator\components\com_workflow\src\Model\TransitionModel.php on line 262
Edit a transition.
Undefined index: workflow_id in \administrator\components\com_workflow\src\Model\TransitionModel.php on line 262
Thx
Edit and save a transition.
PHP Notice: Undefined variable: pk in \administrator\components\com_workflow\src\Model\TransitionModel.php on line 143
| Category | Administration Language & Strings Libraries com_content com_workflow Modules | ⇒ | Administration com_content com_workflow Language & Strings Modules |
I have tested this item
Thanks to Benjamin for helping me through this one. We discovered an interesting quirk with the display but the permissions worked both in the overall and in the specifics for each workflow
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29263.
I have tested this item
Tested several permission variations
- Viewing Workflows
- Creating Workflows
- Deleting Workflows
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29263.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29263.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-13 16:37:23 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Thank you!