[#29257] - [4.0] [WIP] Add support for TinyMCE content_css
- Closed
- 18 Oct 2020
- Medium
- Build: 4.0-dev
- # 29257
- Diff
- C-Lodder:tiny-css
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
TinyMCE has the ability to set the editor theme, however there are 2 parts to this:
- The editor wrapper (skin)
- The content itself
Until now, Joomla has only supported setting the Skin and has included its own editor.css file.
What this PR does is:
- Remove the old Template CSS Classes parameter.
- Adds 2 new parameters (site/admin) to set the Content CSS.
- Maintains support for using a
editor.cssfile, only if specified.
Testing Instructions
- Open TinyMCE in your Plugin Manager
- Click on the
Set 0tab - Set the
Site/Administrator Content CSSoption todark
Actual result
The whole editor is now a dark theme:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
Doesnt this prevent a template from shipping an editor.css file ?
@brianteeman Technically no, but you would have to explicitly set the Custom CSS Classes option to editor.css if you wanted to use it. Could re-add the auto detection, but will close in favour of: #29259
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-29 17:28:46 |
| Closed_By | ⇒ | C-Lodder | |
| Labels |
Added:
?
?
|
||
as its closed its not an issue any more as that pr doesnt change template css
@dgrammatiko I'll wait until this is merged
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-05-29 17:28:46 | ⇒ | |
| Closed_By | C-Lodder | ⇒ |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29257.
I have tested this item
Default + pr:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29257.
| Labels |
Added:
Conflicting Files
|
||
I've solved the conflict. It was just in the language strings so previous tests are still valid.
Will set it RTC as soon as I can see the automated tests are passing.
Richard, this currently breaks B/C a little
I have tested this item
I was testing as well but other tester had not filled in in the sheet so its for extra tests!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29257.
@richard67 see this #29257 (comment)
Let me revisit it this weekend
@richard67 see this #29257 (comment)
Let me revisit it this weekend
@C-Lodder Ok, thanks in advance. I'll set the "Updates Requested" label so nobody sets RTC. Let me know when I shall remove that label.
I'm going to close this as it's been too long since I last worked on it, and I'm too burned out to continue the thought process.
Will leave the branch open it anyone wants to continue with it.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-18 15:31:27 |
| Closed_By | ⇒ | C-Lodder | |
| Labels |
Added:
?
Removed: Conflicting Files |
||
This is wrong, the tinyMCE theming should follow the regular Joomla overriding way, eg to override a theme you should just place the new theme in the template
css/vendor/...blabla. No options needed also it's the expected way. Let's do this properly not introducing exceptions. It's my fault I should have done this the right way many years ago when I introduced the theming option.BTW the code already exists here: #14510EDIT: So after reading a bit on the new features of tinyMCE and some talk with @C-Lodder I was wrong this is fine! Anyway I was talking about the skin this is about the content, not the same thing apparently