[#29251] - [4.0] Restore com_admin profile view
- Fixed in Code Base
- 3 Jul 2020
- Urgent
- Build: 4.0-dev
- # 29251
- Diff
- SharkyKZ:j4/com_admin
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25440.
Summary of Changes
Restores profile view in com_admin.
Testing Instructions
Test that editing profile using Edit Account link in mod_user dropdown works correctly. Especially functionality added by plugins (Token, TFA, action logs).
Documentation Changes Required
If the removal was documented somewhere, it should be reverted.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_users Language & Strings Modules Front End Plugins |
| Labels |
Added:
?
?
?
|
||
The problem we had before with com_admin was that not all user options would be loaded. With this PR for example then the accessibility tab isn't displayed (
With this PR for example then the accessibility tab isn't displayed (
Because accessibility settings are hardcoded in com_users form. This is solved with #29226. The alternatives are to use com_users form in com_admin or just copy/paste the settings into com_admin form.
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
Add password strength meter?
I cant help but think this is the wrong solution to the problem. Having to maintain the same code in multiple places....
@brianteeman There are ways of reducing code duplication here. We could use the form from com_users and TFA rendering could be moved to JLayout.
Besides, this contains some logic which is not present in com_users, like username compliance check.
Please fix conflicts.
Conflicts fixed.
| Priority | Medium | ⇒ | Urgent |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29251.
Conflicts fixed. JHELP_ADMIN_USER_PROFILE_EDIT can be removed for now. I'll just have to re-add it in this PR.
Are we supposed to get an Action in Home Dashboard Latest Actions when modifying profile?
If I modify the user account, I do get a log.
@infograf768 I guess we could add this. Currently doesn't work in staging either.
Maybe separate. This could be fixed in staging too.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29251.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29251.
What would be the right solution?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-03 06:34:31 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
Removed: ? |
||
Tks.
May I ask why?