User tests: Successful: Unsuccessful:
Pull Request for Issue # .
When latest changes of the staging branch, which include PR #29117 , will be merged up into 3.10-dev, the utf8mb4 conversion in J4 has to be adapted to these changes so it doesn't run if not needed.
This is done with this Pull Request (PR) here.
As long as the upmerge has not happened yet, I'll keep this PR in draft status on GitHub and with "[WiP]" (work in progress) in the title.
Ideally both the upmerge from staging to 3.10-dev and the merge of this PR here happen before J4 Beta 1 is built, so that people can test updates from 3.10 to 4 using the latest 3.10 nightly as starting point.
Code review with respect to the changes in PR #29117 is sufficient.
But if someone insists on a real test ....
return false;
before the following line:serverClaimsUtf8mb4Support
always returns false.php.ini
or .user.ini
file:log_errors = On;
error_log = "/full-path-to-log-folder/php-errors.log";
This test shall show that new installation is not broken by this PR.
Apply the patch of this PR to a clean 4.0-dev staging branch or a 4.0-beta1-dev nightly build.
Make a new installation into an empty database.
Log in to backend and go to "System - Information - Database".
Result: No database error is shown.
#__utf8_conversion
exists (replace #__
by your database prefix).Result: The table doesn't exist.
Result: All database tables have collation utf8mb4_unicode_ci
.
Result: No SQL errors, all database tables have utf8mb4_unicode_ci collation.
'DEBUG: Running utf8mb4-conversion.sql.'
or 'DEBUG: Running utf8mb4-conversion_optional.sql.'
.Result: No such logs.
On a clean 3.0-dev from right now, or the next nightly build from tonight, patch the database driver as described in item 3 of the preconditions section above.
Make a new installation.
Result: All database tables have utf8_unicode_ci or utf8_general_ci collation.
Result: No SQL errors, all database tables have utf8mb4_unicode collation.
'DEBUG: Running utf8mb4-conversion.sql.'
or 'DEBUG: Running utf8mb4-conversion_optional.sql.'
.Result: Both logs are shown if table #__core_log_searches
existed before the update, otherwise only the first log is shown.
When updating a 3.10-dev which is not converted yet to utf8mb4, the conversion runs as well as before when updating to 4.
When updating a 3.10-dev which is already on utf8mb4, the conversion doesn't run when updating to 4.
The utf8mb4 conversion runs also if a 3.10-dev which is already on utf8mb4 is updated to 4.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin Libraries |
Labels |
Added:
?
|
Category | Administration com_admin Libraries | ⇒ | Administration com_admin |
wait there is missing something
Ah, no, all ok.
Title |
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-30 09:54:57 |
Closed_By | ⇒ | wilsonge |
Thanks!
@richard67 can you get this one ready please