Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#29237] - Fix feed image

? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
27 May 2020

Once it reaches 4.0, this PR will solve #29236.

Summary of Changes

Fixes feed image display.

Testing Instructions

Create a feed module. Use a feed link containing an image, e.g. http://feeds.bbci.co.uk/news/world/europe/rss.xml.
View the module.

Expected result

Image is shown.

Actual result

Image not shown.

Documentation Changes Required

No.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00
avatar SharkyKZ SharkyKZ - open - 27 May 2020
avatar SharkyKZ SharkyKZ - change - 27 May 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 May 2020
Category ⇒ Modules Administration Front End com_newsfeeds Libraries
avatar toivo toivo - test_item - 27 May 2020 - Tested successfully
avatar toivo
toivo - comment - 27 May 2020

I have tested this item ✅ successfully on 4de3ebb

Tested successfully in Joomla 3.9.19-dev Nightly Build of 27 May.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29237.

avatar pmleconte pmleconte - test_item - 27 May 2020 - Tested successfully
avatar pmleconte
pmleconte - comment - 27 May 2020

I have tested this item ✅ successfully on 4de3ebb

Tested this on Joomla 3.9.18

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29237.

avatar SharkyKZ SharkyKZ - change - 27 May 2020
Status Pending ⇒ Ready to Commit
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 27 May 2020

RTC.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29237.

avatar wilsonge wilsonge - change - 15 Jun 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-06-15 21:37:41
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 15 Jun 2020

Thanks!

avatar wilsonge
wilsonge - comment - 15 Jun 2020

My guess is that this stemmed from the fact this used to be included through CDATA tags https://stackoverflow.com/questions/483675/images-in-rss-feed - we maybe want to handle this case still in 3.x?

avatar SharkyKZ
SharkyKZ - comment - 16 Jun 2020

@wilsonge I don't think that's related. This PR concerns main image of the channel, not images of entries. It's created here:

joomla-cms/libraries/src/Feed/Parser/RssParser.php

Lines 135 to 153 in 4314047

protected function handleImage(Feed $feed, \SimpleXMLElement $el)
{
// Create a feed link object for the image.
$image = new FeedLink(
(string) $el->url,
null,
'logo',
null,
(string) $el->title
);
// Populate extra fields if they exist.
$image->link = (string) $el->link;
$image->description = (string) $el->description;
$image->height = (string) $el->height;
$image->width = (string) $el->width;
$feed->image = $image;
}

Add a Comment

Login with GitHub to post a comment