Feeling Lucky
?
[#29232] - [4.0] Reviewing Tag Model and Tag Table
- Fixed in Code Base
- 28 May 2020
- Medium
- Build: 4.0-dev
- # 29232
- Diff
- Hackwar:j4tagscontroller
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
While refactoring the content history feature, I noticed some inconsistencies in the Tag model and the Tag table.
What happened in the Tag model?
- Fixed docblock for $table
- Wrapping everything in a try-catch-block, like it is done in other models.
- Move all JSON encoding to the table class.
- Remove "rules" handling. We don't have any access management for tags.
- Set the "new" state properly.
What happened in the Tag table?
- properly fill the $_jsonEncode attribute, which allows to delete the whole bind() method.
How to test
There should be no difference to before.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Administration |
bonzani
- comment
- 28 May 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29232.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 28 May 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29232.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-28 18:36:38 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 28 May 2020
Thanks!
I have tested this item✅ successfully on 9edac4a
Tested successfully in Nightly Build of 27 May in Wampserver 3.2.1 MySQL 8.0.19 PHP 7.4.5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29232.