Pending

User tests: Successful: Unsuccessful:

avatar Kostelano
Kostelano
24 May 2020

@brianteeman (as the author PR #29125)

Summary of Changes

For version 3.9.19, changes were made to the localization files, see #29125.

COM_PRIVACY_CONFIRM_REQUEST_SUCCEEDED="Your information request has been confirmed. We will process your request as soon as possible and the export will be sent to your email."

I suggest shortening this line for several reasons:

  1. The user can create a request to DELETE his data and in this case the message confirming the request will not correspond to reality, because pressing the DELETE button in the control panel DOES NOT send a copy of the data to the address of this user.

  2. Even assuming that before deleting, you can send a copy of the data to the user by mail - this is impossible, because the send data button is not available if the user has selected a request to delete data (see screenshot).

Screenshot_1


By the way, it would be good to implement the function of automatically sending a notification to the user’s address about DELETING his data from the site. For example, how this is done for the export option:

COM_PRIVACY_EMAIL_DATA_EXPORT_COMPLETED_BODY="An administrator for [URL] has completed the data export you requested and a copy of the information can be found in the file attached to this message."

In this case, we could write something like this (universal for all options) in the request confirmation message:

COM_PRIVACY_CONFIRM_REQUEST_SUCCEEDED="Your information request has been confirmed. We will process your request as soon as possible and a notification will be sent to your email."

avatar Kostelano Kostelano - open - 24 May 2020
avatar Kostelano Kostelano - change - 24 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2020
Category Language & Strings
avatar brianteeman
brianteeman - comment - 24 May 2020

LGTM

avatar jwaisner jwaisner - test_item - 5 Jun 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 5 Jun 2020

I have tested this item successfully on 19fd3af

Language string update looks good.

I agree that there should be some added functionality but that will be for another PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29211.

avatar jwaisner jwaisner - change - 5 Jun 2020
Priority Medium Low
avatar Kostelano Kostelano - change - 19 Jun 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-06-19 19:21:24
Closed_By Kostelano
avatar Kostelano Kostelano - close - 19 Jun 2020

Add a Comment

Login with GitHub to post a comment