[#29204] - TinyMCE size units not working
- Fixed in Code Base
- 26 May 2020
- Medium
- Build: staging
- # 29204
- Diff
- SharkyKZ:j3/xml/tinymce-width-height
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fixes #29181.
Summary of Changes
Fixes size units not working in TinyMCE.
Testing Instructions
Edit TinyMCE plugin.
Set HTML Width to 50%.
View a page containing TinyMCE editor.
Expected result
Editor is 50% wide.
Actual result
Editor is 100% wide.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Rel_Number | ⇒ | 29181 | |
| Relation Type | ⇒ | Pull Request for | |
| Labels |
Added:
?
|
||
@SharkyKZ Is the test run on the backend?
How do I reduce the percentage? TinyMCE is not in the plugin list.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29204.
- Apply a PR
- Change the value of HTML Width to 375
The plugin screen changes
@SharkyKZ Started to test in Nightly Build of 24 May, which does not seem to be the right test environment because of the following inconsistencies in the plugin Editor - TinyMCE:
- HTML Width is pixels, not percentage, in the Advanced tab
- the Advanced tab displays language strings, for example PLG_TINY_FIELD_HTMLWIDTH_DESC
- the Plugin tab displays PHP warning:
Warning: htmlspecialchars() expects parameter 1 to be string, array given in C:\www\joomla4\layouts\joomla\form\field\text.php on line 93
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29204.
I have tested this item
Started to test in Nightly Build of 24 May but stopped because HTML Width is pixels, language string untranslated and PHP warning.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29204.
I adding a feature.
By setting the default parameters, I disable the PR, return to the plugin and have:
@SharkyKZ - Sorry, need to check [4.0] first...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29204.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29204.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29204.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-26 12:39:13 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on 2dea258
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29204.