? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
21 May 2020

Pull Request for Issue #29177.

Summary of Changes

Change 1.0 and 2.0 to 1 and 2.

Testing Instructions

  1. Go to your Plugin Manager and open Codemirror
  2. Click on the Appearance Options tab
  3. Set the Line Height to 2.0
  4. Click Save

Expected result

The parameter shows as 2.0

Actual result

The parameter shows as 1.0

avatar Quy Quy - open - 21 May 2020
avatar Quy Quy - change - 21 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2020
Category Front End Plugins
avatar richard67 richard67 - test_item - 21 May 2020 - Tested successfully
avatar richard67
richard67 - comment - 21 May 2020

I have tested this item successfully on 894a483

Fixes the issue + all other line heights still work, too.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29194.

avatar ChristineWk ChristineWk - test_item - 21 May 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 21 May 2020

I have tested this item successfully on 894a483


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29194.

avatar Quy Quy - change - 21 May 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 21 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29194.

avatar wilsonge wilsonge - close - 21 May 2020
avatar wilsonge wilsonge - merge - 21 May 2020
avatar wilsonge wilsonge - change - 21 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-21 20:27:41
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 21 May 2020

Thanks!

Add a Comment

Login with GitHub to post a comment