? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
20 May 2020

Pull Request for Issue #29177.

Summary of Changes

Remove float filter since there is already options validation.

Testing Instructions

  1. Go to your Plugin Manager and open Codemirror
  2. Click on the Appearance Options tab
  3. Set the Line Height to 2.0
  4. Click Save

Expected result

The parameter shows as 2.0

Actual result

The parameter shows as 1.0

Documentation Changes Required

avatar Quy Quy - open - 20 May 2020
avatar Quy Quy - change - 20 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2020
Category Front End Plugins
avatar toivo toivo - test_item - 21 May 2020 - Tested successfully
avatar toivo
toivo - comment - 21 May 2020

I have tested this item successfully on 0d8a4ca

Tested successfully in Nightly Build of 21 May


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29185.

avatar SharkyKZ
SharkyKZ - comment - 21 May 2020

@Quy Instead of removing the filter, the 1.0 and 2.0 values should be changed to 1 and 2. This way we get to keep float data type. And can you make this against staging instead?

avatar adj9
adj9 - comment - 21 May 2020
  • Parameter modification with 2.0
  • Exit and return of the plg

The parameter is 2.0 with a reallocation of the objects on the page.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29185.

avatar adj9
adj9 - comment - 21 May 2020

I add a feature.
Returning to the backend, I have a location of the objects on the page with the 1.0 parameter, without changing anything.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29185.

avatar Quy
Quy - comment - 21 May 2020

Closing in favor of #29194

avatar Quy Quy - change - 21 May 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-05-21 14:51:56
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 21 May 2020

Add a Comment

Login with GitHub to post a comment