? ? Pending
Pull Request for # 29173

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
20 May 2020

Fixes #29173.

Summary of Changes

Omits tooltip when empty.
Also corrects menu item icons in modal layout.

Testing Instructions

Create an article.
In the editor click CMS Content -> Menu.
Hover over icons in "Home" column.

Expected result

Nothing or tooltip with text shown.

Actual result

Empty tooltip:

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 20 May 2020
avatar SharkyKZ SharkyKZ - change - 20 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2020
Category Administration com_menus Libraries
avatar SharkyKZ SharkyKZ - change - 20 May 2020
Rel_Number 29173
Relation Type Pull Request for
Labels Added: ?
avatar Quy
Quy - comment - 20 May 2020

Fix it so that the icon is not wrapped in link tag?

<a class="tbody-icon circle-disabled disabled jgrid"><span class="icon-circle" aria-hidden="true"></span></a>

avatar SharkyKZ
SharkyKZ - comment - 20 May 2020

@Quy done.

avatar Quy Quy - test_item - 20 May 2020 - Tested successfully
avatar Quy
Quy - comment - 20 May 2020

I have tested this item successfully on 021f616


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29179.

avatar ChristineWk ChristineWk - test_item - 20 May 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 20 May 2020

I have tested this item successfully on 021f616


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29179.

avatar Quy Quy - change - 20 May 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 20 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29179.

avatar wilsonge wilsonge - change - 21 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-21 10:27:54
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 21 May 2020
avatar wilsonge wilsonge - merge - 21 May 2020
avatar wilsonge
wilsonge - comment - 21 May 2020

Thanks!

Add a Comment

Login with GitHub to post a comment