? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
20 May 2020

Summary of Changes

In the administrator part of Smart Search, search statistics option appears to be disabled but in frontend statistics are still gathered. This changes default value of statistics option in frontend to disabled.

Also renames logging_enabled parameter to gather_search_statistics to avoid confusion with enable_logging.

Testing Instructions

In backend go to Components -> Smart Search -> Statistics.
Notice the warning:

Gathering of statistics is disabled. Enable it in the Options.

Go to frontend. Perform a search using Smart Search.
Go back to statistics page.

Expected result

No entries logged.

Actual result

Search entry logged.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 20 May 2020
avatar SharkyKZ SharkyKZ - change - 20 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2020
Category Administration com_finder Front End
avatar SharkyKZ SharkyKZ - change - 20 May 2020
Labels Added: ?
avatar SharkyKZ SharkyKZ - change - 20 May 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 20 May 2020
avatar toivo toivo - test_item - 20 May 2020 - Tested successfully
avatar toivo
toivo - comment - 20 May 2020

I have tested this item successfully on 3b27551

Tested successfully in Nightly Build of May 20.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29164.

avatar Quy Quy - test_item - 20 May 2020 - Tested successfully
avatar Quy
Quy - comment - 20 May 2020

I have tested this item successfully on 3b27551


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29164.

avatar Quy Quy - change - 20 May 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 20 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29164.

avatar richard67
richard67 - comment - 21 May 2020

@SharkyKZ Could you update the branch of this PR to latest 4.0-dev of the CMS? It needs to do that in order to make drone pass, and this is needed for merging (except someone merges who has permission to force merge, which I haven't). Wait, I first try it with restarting drone.

avatar SharkyKZ SharkyKZ - change - 24 May 2020
Labels Added: ?
avatar zero-24
zero-24 - comment - 24 May 2020

Merging thanks @SharkyKZ

avatar zero-24 zero-24 - change - 24 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-24 09:31:38
Closed_By zero-24
avatar zero-24 zero-24 - close - 24 May 2020
avatar zero-24 zero-24 - merge - 24 May 2020

Add a Comment

Login with GitHub to post a comment