? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
19 May 2020

Summary of Changes

Removes some leftover code from before parameterized queries, fixing filtering by author alias.
Also parameterizes one query.

Testing Instructions

Create an article. Enter something into Created by Alias field.
Create Aritcles - Category module.
Select some aliases in Author Aliases field (Filtering Options tab).
View the module in frontend.

Expected result

Works.

Actual result

Argument 1 passed to Joomla\Database\DatabaseQuery::bindArray() must be of the type array, string given,

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 19 May 2020
avatar SharkyKZ SharkyKZ - change - 19 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2020
Category Front End com_content
avatar SharkyKZ SharkyKZ - change - 20 May 2020
Labels Added: ?
avatar adj9 adj9 - test_item - 21 May 2020 - Not tested
avatar adj9
adj9 - comment - 21 May 2020

I have not tested this item.

Inserting the alias of an article I have no subtraction of the remaining belonging to the category.

Do I understand the objective of PR well?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29160.

avatar SharkyKZ
SharkyKZ - comment - 21 May 2020

I don't think so. There's Created by Alias field in Publishing field of article form. You need to create some articles and enter some values in this field:

Screenshot_2020-05-21 Articles Edit - Joomla - Administration

Then publish Articles - Category module and select some values in Author Aliases field:

Untitled

avatar adj9
adj9 - comment - 21 May 2020

Okay, it's true.
Now I understand the question.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29160.

avatar Quy Quy - test_item - 22 May 2020 - Tested successfully
avatar Quy
Quy - comment - 22 May 2020

I have tested this item successfully on dc854f6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29160.

avatar alikon alikon - test_item - 23 May 2020 - Tested successfully
avatar alikon
alikon - comment - 23 May 2020

I have tested this item successfully on dc854f6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29160.

avatar alikon alikon - change - 23 May 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 23 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29160.

avatar zero-24 zero-24 - change - 23 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-23 22:20:24
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 23 May 2020
avatar zero-24 zero-24 - merge - 23 May 2020
avatar zero-24
zero-24 - comment - 23 May 2020

Merging thanks. ?

Add a Comment

Login with GitHub to post a comment