[#29148] - [4.0] AfterDelete events to return void
- Fixed in Code Base
- 21 May 2020
- Medium
- Build: 4.0-dev
- # 29148
- Diff
- SharkyKZ:j4/cleanup/afterDelete
User tests: Successful: Unsuccessful:
Summary of Changes
The return values of after delete events are not used. Unless they should be, this changes them to be void.
Testing Instructions
Code review or try deleting some stuff. Should work like before.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
It is already documented as void. E.g. https://docs.joomla.org/Special:MyLanguage/Plugin/Events/Content#onContentAfterDelete
Also removing a provided true and false in case of an error seams to be wrong.
We don't use these values in core, i.e. returning false does nothing, unlike with BeforeDelete events. And 3PDs can't rely on these values as well because we don't return them consistently. If you see a use for boolean values here, we could switch to booleans instead. But then we still could not rely on them until 3PDs consistently start returning booleans as well.
Ok didn't checked the docu so seams to make sense to remove it.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29148.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-21 22:35:18 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Changing this behavior is a b/c break and have to be deprecated or at least documented.
Also removing a provided true and false in case of an error seams to be wrong.