? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
15 May 2020

Summary of Changes

Explicit cast because PostgreSQL returns integers for integer columns.

Testing Instructions

Code review is fine. If you want real test (PostgreSQL only):

Create and then edit some content.
View content history.
Enable "Keep Forever" option for some version.
Try to deleted that version.

Expected result

Version not deleted.

Actual result

Version deleted.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 15 May 2020
avatar SharkyKZ SharkyKZ - change - 15 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2020
Category Administration com_content com_contenthistory
avatar Quy Quy - test_item - 16 May 2020 - Tested successfully
avatar Quy
Quy - comment - 16 May 2020

I have tested this item successfully on 21e7c1e

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29115.

avatar richard67 richard67 - test_item - 16 May 2020 - Tested successfully
avatar richard67
richard67 - comment - 16 May 2020

I have tested this item successfully on 21e7c1e

Code review + real test with PostgreSQL (PDO).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29115.

avatar richard67 richard67 - change - 16 May 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 16 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29115.

avatar richard67 richard67 - change - 16 May 2020
Labels Added: ? ?
avatar zero-24 zero-24 - change - 20 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-20 11:57:29
Closed_By zero-24
Labels
avatar zero-24 zero-24 - close - 20 May 2020
avatar zero-24 zero-24 - merge - 20 May 2020
avatar zero-24
zero-24 - comment - 20 May 2020

merging thanks, @SharkyKZ

Add a Comment

Login with GitHub to post a comment