Joomla! Issue Tracker | Joomla! CMS #29105 - [4.0] Disabled toolbar action still triggered on click

Closed
21 Oct 2020
Medium
Build: staging
# 29105

C-Lodder
15 May 2020

Steps to reproduce the issue

Go to administrator/index.php?option=com_content&view=articles
Click one of the checkboxes for any published article to select it
Click on the Actions toolbar button
Click Publish from the dropdown

Expected result

Should not do anything

Actual result

Executes the action and display an error alert

Additional Notes

pointer-events: none; is being set to the button child, however this has no efect as the click event is occuring on the custom element (parent)

C-Lodder - open - 15 May 2020

joomla-cms-bot - change - 15 May 2020

Labels

Added: ?

joomla-cms-bot - labeled - 15 May 2020

C-Lodder - change - 15 May 2020

The description was changed

C-Lodder - edited - 15 May 2020

adj9 - comment - 16 May 2020

Confirmed the error.
A warning should be issued

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29105.}

C-Lodder - comment - 16 May 2020

@adj9 A warning shouldn't be issued. If the dropdown item appears to be disabled, the user shouldn't be allowed to click it

brianteeman - comment - 18 May 2020

This is a very common problem and the only way it can be fixed on a list element is with javascript to remove the href.

Note that if that is done then you will need to add aria-disabled="true"

SharkyKZ - comment - 19 May 2020

This is done intentionally:

joomla-cms/build/media_source/com_content/js/admin-articles-workflow-buttons.es6.js

Lines 155 to 163 in 2e095fb

    
           publishBtn.parentElement.addEventListener('click', (e) => { 
        
             if (publishBtn.classList.contains('disabled')) { 
        
               e.stopImmediatePropagation(); 
        
               Joomla.renderMessages({ error: [Joomla.JText._('COM_CONTENT_ERROR_CANNOT_PUBlISH')] }); 
        
             } else { 
        
               checkTransition(e, 'publish'); 
        
             } 
        
           });

Is it a bad idea?

SharkyKZ - comment - 24 Jul 2020

Looks like the issue is no longer relevant. Now all buttons are enabled.

Quy - change - 21 Oct 2020

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2020-10-21 00:01:55
Closed_By		⇒	Quy

Quy - close - 21 Oct 2020

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#29105] - [4.0] Disabled toolbar action still triggered on click

Steps to reproduce the issue

Expected result

Actual result

Additional Notes

Add a Comment

	publishBtn.parentElement.addEventListener('click', (e) => {
	if (publishBtn.classList.contains('disabled')) {
	e.stopImmediatePropagation();

	Joomla.renderMessages({ error: [Joomla.JText._('COM_CONTENT_ERROR_CANNOT_PUBlISH')] });
	} else {
	checkTransition(e, 'publish');
	}
	});