Feeling Lucky
[#291] - Removing some 'DS' constants and fixing a form-id to 'adminForm'
- Closed
- 12 Nov 2012
- Medium
- Build: master
- # 291
- Diff
- Bakual:master
User tests: Successful: Unsuccessful:
Three fixes:
- 'DS' constants found in language overrides model -- changed to '/'
- 'DS' constant found in finder formfield -- changed to '/'
- ID of search filters edit form was 'item-form' -- changed to 'adminForm'
Bakual
- comment
- 23 Jul 2012
The "item-form" breaks the buttons, you can't save or cancel the form.
It's also noted in the compatibility issues doc :
Forms that have name="adminForm" now also require id="adminForm"
realityking
- comment
- 23 Jul 2012
Got it, indeed it's broken. Will take care of it. Thank you!
Bakual
- comment
- 12 Nov 2012
Closing as it's fixed.
I committed the DS part directly. Do we need the item-form change? Is something broken?