NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 May 2020

Fixes all the useless issues that were created. It was quicker to fix than to post 30 issues.

PS as I have said before and put on the road to beta issue #27812 there needs to be a policy and procedure for this

Pull Request for Issue # far too many to list .

avatar brianteeman brianteeman - open - 14 May 2020
avatar brianteeman brianteeman - change - 14 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2020
Category NPM Change
avatar HLeithner
HLeithner - comment - 14 May 2020

Creating the PR is not the problem you should also write a proper testing description and at least check the release notes of the upstream packages for any b/c

looking at https://jquery.com/upgrade-guide/3.5/ you there some.

Many upstream packages (doesn't matter if composer or npm) doesn't follow semver or as bad as we sometimes on b/c breaks. So doing a code review is often the first thing to do if you can't trust the upstream maintainer.

avatar brianteeman
brianteeman - comment - 14 May 2020

if you can't trust the upstream maintainer.

Then we should not be using their code

avatar HLeithner
HLeithner - comment - 14 May 2020

Then we should not be using their code

true

avatar C-Lodder
C-Lodder - comment - 14 May 2020

@brianteeman I'm creating issues to make a point. I've said several times this task should not be done manually and instead a bot should check daily for outdated deps and create a PR. The PR can then be tested, just like it would be human created PR.

The use of a bot was somewhat frowned upon, yet nobody bothers to update these dependencies.

avatar brianteeman
brianteeman - comment - 14 May 2020

Which is why I put it on the Road to Beta issue

avatar C-Lodder
C-Lodder - comment - 14 May 2020

Yes, over 3 months ago, yet nothing has been done about it and you wouldn't have needed to create this PR

Only takes one of the maintainers a minute to activate a bot on the repo.

avatar HLeithner
HLeithner - comment - 14 May 2020

Doesn't solve the problem that testers doesn't know what to test.

avatar brianteeman
brianteeman - comment - 14 May 2020

We have to accept that not every issue can be tested by everyone

avatar zero-24
zero-24 - comment - 14 May 2020

Doesn't solve the problem that testers doesn't know what to test.

Well what about adding a bot comment by the issue tracker that adds that test instructions?

avatar brianteeman
brianteeman - comment - 14 May 2020

@zero-24 I think Harald was referring to the fact that I did not write test instructions

avatar zero-24
zero-24 - comment - 14 May 2020

Ah ok. :-)

avatar HLeithner
HLeithner - comment - 14 May 2020

A bot wouldn't write test instructions either

avatar zero-24
zero-24 - comment - 14 May 2020

Our bot can check what package is updated and than throw in some default test instructions. Sure it cant parse the change log etc but some basic test instructions can be generated when this is the only concern regarding not using the auto update bot.

avatar zero-24
zero-24 - comment - 14 May 2020

In the end an maintainer has to take a look into the PR anyway. So when there is something special to test in the change log that can be raised and moved back to pending.

avatar brianteeman
brianteeman - comment - 17 May 2020

Closing as by the time someone looks at it it will be out of date

avatar brianteeman brianteeman - close - 17 May 2020
avatar brianteeman brianteeman - change - 17 May 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-05-17 08:12:46
Closed_By brianteeman
Labels Added: NPM Resource Changed ?

Add a Comment

Login with GitHub to post a comment