?
avatar C-Lodder
C-Lodder
14 May 2020

Steps to reproduce the issue

Run node build.js --copy-assets from your terminal

Actual result

If you looks inside media/system/js, you'll notice a directory called core.es6.
This directory is unecessary and contains invalid files

avatar C-Lodder C-Lodder - open - 14 May 2020
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 14 May 2020
avatar HLeithner
HLeithner - comment - 14 May 2020

Can you elaborate this a bit?

avatar C-Lodder
C-Lodder - comment - 14 May 2020

How can I elaborate?

Run node build.js --copy-assets and look at the directory I mentioned. I shouldn't be generated

Not sure how else to explain it

avatar C-Lodder
C-Lodder - comment - 14 May 2020

Untitled

avatar infograf768
infograf768 - comment - 14 May 2020

These come from #26300
I guess they are supposed to replace most of core.es6.js which is still present in build.
I indeed wonder also why we have both in media/ as core.es6.js is recomposed there with their content.

avatar wilsonge
wilsonge - comment - 14 May 2020

I believe the aim was to conditionally load the es6 files on machines that support ES6 (basically everything we run core on at the moment out of the box). Can you explain why you think these files are invalid. I'm often using them to debug things (as it's the equivalent of the raw files used before babel transpiling)

avatar HLeithner
HLeithner - comment - 14 May 2020

The files are invalid because they are compiled to core.es6.js, that are only the plain source files for copyright reasons.

avatar C-Lodder
C-Lodder - comment - 14 May 2020

@wilsonge last time I checked, there was no such thing as a .es6 file extension.

Note .es6 vs .es6.js

avatar wilsonge
wilsonge - comment - 25 May 2020

Ahh sorry I understand now. Yup that's all invalid and rubbish indeed

avatar wilsonge wilsonge - change - 25 May 2020
Labels Added: ?
avatar wilsonge wilsonge - labeled - 25 May 2020
avatar SharkyKZ SharkyKZ - change - 22 Oct 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-10-22 08:53:31
Closed_By SharkyKZ
avatar SharkyKZ SharkyKZ - close - 22 Oct 2020
avatar SharkyKZ
SharkyKZ - comment - 22 Oct 2020

Please test PR #31201.

avatar wilsonge wilsonge - change - 18 Dec 2020
Labels Removed: ?
avatar wilsonge wilsonge - unlabeled - 18 Dec 2020

Add a Comment

Login with GitHub to post a comment