? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
14 May 2020

Pull Request for Issue #29039

Summary of Changes

Using Text method to translate the description

Testing Instructions

See #29039

Can be tested/merged on review.

avatar infograf768 infograf768 - open - 14 May 2020
avatar infograf768 infograf768 - change - 14 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2020
Category Administration com_installer
avatar SharkyKZ
SharkyKZ - comment - 14 May 2020

Doesn't work. Language files aren't loaded.

avatar infograf768
infograf768 - comment - 14 May 2020

I have no extension to test, but the example in #29039 displays a constant, which means the string exists and displayed. Is'nt it?

avatar SharkyKZ
SharkyKZ - comment - 14 May 2020

I see the issue now. In J3 we use description from remote update file and in J4 from extension's manifest file. I don't know why this change was made. Looks like it's by mistake.

avatar richard67
richard67 - comment - 14 Jun 2020

I see the issue now. In J3 we use description from remote update file and in J4 from extension's manifest file. I don't know why this change was made. Looks like it's by mistake.

Possibly @zero-24 knows if that has been changed by purpose?

avatar zero-24
zero-24 - comment - 14 Jun 2020

I can not follow what the issue here is nor how i can help on that? Any more context might help?

avatar richard67
richard67 - comment - 14 Jun 2020

@zero-24 When you hover over the extension names in the list of available updates (if any) you het a tool tip with the description of the extension. In J3 we use description from remote update file and in J4 from extension's manifest file. I thought maybe you know where this difference between J3 and J4 comes from since I remember you worked much on extension update checks.

avatar zero-24
zero-24 - comment - 14 Jun 2020

I'm not aware of why this might has been changed.

avatar SharkyKZ
SharkyKZ - comment - 15 Jun 2020

My 2c says this was changed by mistake. See PR #29619 for changing back to use remote XML description.

avatar wilsonge wilsonge - change - 15 Jun 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-06-15 21:24:06
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 15 Jun 2020
avatar wilsonge
wilsonge - comment - 15 Jun 2020

Merged #29619 so closing this

Add a Comment

Login with GitHub to post a comment