Feeling Lucky
?
?
[#29044] - [4.0] Change .center to .text-center
- Fixed in Code Base
- 16 May 2020
- Medium
- Build: 4.0-dev
- # 29044
- Diff
- Quy:text-center
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
center is not a valid class. Use text-center.
Testing Instructions
Code review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_banners com_fields com_installer com_tags |
Quy
- comment
- 12 May 2020
This PR changes administration files only where Bootstrap 4 is allowed and applies to table cells. Please don't assume and actually test.
richard67
- comment
- 13 May 2020
@Quy I have reset the test result of @grantg182 to "Not tested" in the issue tracker, since it was definitely not a valid test but just a statement based on wrong assumptions.
Fedik
- comment
- 13 May 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29044.
ChristineWk
- comment
- 13 May 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29044.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 13 May 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29044.
| Labels |
Added:
?
?
|
||
brianteeman
- comment
- 16 May 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29044.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-16 22:09:00 |
| Closed_By | ⇒ | Quy | |
| Labels | |||
I have tested this item? unsuccessfully on 91af993
"text-center" is a Bootstrap helper class which only works on "display: inline" elements, in both Bootstrap 3 and 4. I don't see how this fixes the fundamental issue here because Bootstrap is not a front-end requirement. Furthermore, I suspect the actual problem with this code is the fact it is using "class" and not "align" (i.e. was probably the intention) as per some dinosaur HTML spec.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29044.