Feeling Lucky
?
?
Pending
[#29027] - [4.0] Replace inline style width 3%, 6%, 7% with w-3, w-6, w-7
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Continuation of PR #28692
Summary of Changes
Add w- classes.
Replace inline style widths % with w-.
Testing Instructions
Code review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_content com_templates com_users com_workflow Templates (admin) |
| Title |
|
||||||
richard67
- comment
- 11 May 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29027.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 11 May 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29027.
| Labels |
Added:
?
?
|
||
brianteeman
- comment
- 11 May 2020
I understand and agree with the addition of the larger numbers - but this is really going too far. Why stop at w-3, w-6, w-7 whats wrong with w-4, w-8 and w-9
Quy
- comment
- 11 May 2020
I am just going through the existing values. There is one more round to do. Then these can be adjusted/rounded up if desired to reduce the number of sizes.
Quy
- comment
- 12 May 2020
I am going to keep it as it. The only difference is that it is now class and not style.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-13 05:18:42 |
| Closed_By | ⇒ | infograf768 | |
| Labels | |||
infograf768
- comment
- 13 May 2020
tks
I have tested this item✅ successfully on 2b79b2e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29027.