[#29022] - [4.0] WebAssets and Cache enabled
- Fixed in Code Base
- 24 May 2020
- Medium
- Build: 4.0-dev
- # 29022
- Diff
- Fedik:asset-caching
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28727 .
Summary of Changes
Store/Restore Asset Manager state for caching, with HtmlDocument::get[set]HeadData()
Testing Instructions
Apply patch.
Enable caching in global configuration.
Create a CustomHTML module with next content:
<p class="much-red">test cache</p>
Edit modules/mod_custom/tmpl/default.php, add:
$wa = $app->getDocument()->getWebAssetManager();
$wa->addInlineStyle('.much-red{color:red; font-weight:bold;}');Open the page with module.
Expected result
The text color in the module should be red after each page refresh.
Actual result
The text is red only after first load (or after clearing the cache), and stays black on future page refresh
Documentation Changes Required
none
@wilsonge please review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
@richard67 #28990 is about old _script/_style declarations of the Document, that do not cover WebAsset
I have tested this item
Worked as advertised with Conservative and Progressive cacheing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29022.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29022.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29022.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-24 20:04:15 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
@Fedik Is that somehow related to the recently merged PR #28990 ? At least the description reads similar to me.