[#29016] - [4.0] com_menu - Change Featured Icon to Home Icon in
- Fixed in Code Base
- 13 May 2020
- Medium
- Build: 4.0-dev
- # 29016
- Diff
- coolcat-creations:home-icon-for-menus
User tests: Successful: Unsuccessful:
Pull Request for Issue #28976
Summary of Changes
Changed the Default Icon in Menus to a home icon. If it has to be called home or default could be discussed in another issue. This PR makes a difference between the featured - action and the set menu item as default action. It also adds the possibility to pass the active and inactive iconclass suffix to the isDefault method.
Testing Instructions
apply patch
see if the home Icon on monolingual sites is now a home icon
the non-default items are for now a simple circle
on a multilingual website the home icon should be still a flag like before.
Expected result
Sidebar:
Actual result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Libraries |
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Category | Administration com_menus Libraries | ⇒ | Administration com_menus Templates (admin) Libraries |
| Category | Administration com_menus Libraries Templates (admin) | ⇒ | Administration com_menus Modules Templates (admin) Libraries |
Yes, this PR is only about to change the type of the icon, not the color or size - for color we would need another class in the table header and for sizes it’s also not bound to only the home icon but the general interface. see later comment :-)
I have tested this item
Apply the PR and I've change the icon for menu.
I've do an article in person lang and see the icon should
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29016.
I have tested this item
✅ successfully on 109a7b2Apply the PR and I've change the icon for menu.
I've do an article in person lang and see the icon should
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29016.
Thank you!
@adj9 @infograf768 I added the styling for the home item to not have the disabled class and added a "not-allowed" cursor. Can you retest?
For the icon sizes I think a separate PR would be better.
will do tomorrow.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29016.
I suggest you also add a few lines above
&.featured-disabled {
opacity: 1;
}
as this will now also solve density in Installed Languages and Template Styles for the default star colour.
&.disabled .icon-home {
color: $state-warning-bg;
border-color: $state-warning-bg;
}
should be
&.disabled .fas.fa-home,
&.disabled .icon-home {
color: $state-warning-bg;
border-color: $state-warning-bg;
}
While below is preferred, I understand for b/c reasons that may not be possible at this time.
&.disabled .fas.fa-home {
color: $state-warning-bg;
border-color: $state-warning-bg;
}
&.featured-disabled {
opacity: 1;
}
@infograf768 - May I create a seperate PR for that? I prefer not to mix up too much in case something needs to be looked up later or reverted.
@infograf768 - May I create a seperate PR for that? I prefer not to mix up too much in case something needs to be looked up later or reverted.
Sure, but don’t forget!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29016.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29016.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29016.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-13 05:21:35 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
Tks
@coolcat-creations
Now you can make the PR for #29016 (comment) ;)
Remark 1:
Size of icon is very different between sidemenu and Menu dasboard. Menu dashboard is better imho.
Remark 2:
Density of Yellow is very different between the featured star (for articles manager) and Home icon set to All languages in menu items manager. Articles manager star density is better imho.
The same colour is applied
The issue comes from
These "issues" are unrelated to this patch but it would be good to solve them at the same time.