? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
9 May 2020

Pull Request for Issue #28963
Redo of #28964

Summary of Changes

As title says. Normalizes vs other category edit fields (see Note)

Testing Instructions

Create a multilingual site
Make sure you have tagged some categories to a Content Language.
In categories manager, select a category and click on the batch Toolbar button
Look into the category field (select field under To Move or Copy your selection please select a Category.)

Before patch

Screen Shot 2020-05-09 at 09 34 49

After patch

Screen Shot 2020-05-09 at 09 35 59

Note

This has already been done for other categories dropdowns fileds.

Screen Shot 2020-05-09 at 09 39 47

.
avatar infograf768 infograf768 - open - 9 May 2020
avatar infograf768 infograf768 - change - 9 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2020
Category Libraries
avatar richard67 richard67 - test_item - 10 May 2020 - Tested successfully
avatar richard67
richard67 - comment - 10 May 2020

I have tested this item successfully on 43f182d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29003.

avatar Quy Quy - test_item - 10 May 2020 - Tested successfully
avatar Quy
Quy - comment - 10 May 2020

I have tested this item successfully on 43f182d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29003.

avatar Quy Quy - change - 10 May 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 10 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29003.

avatar HLeithner
HLeithner - comment - 12 May 2020

I'm not really happy with this because the addition is every technical, it uses the tag of the language but as user I would expect my language title.

avatar infograf768
infograf768 - comment - 12 May 2020

We evidently can't add the language name for reasons of spce in these dropdowns...

Also as I said, this is already implemented for the other category fields...
I frankly don't understand your comment.

avatar HLeithner HLeithner - change - 12 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-12 09:41:26
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 12 May 2020
avatar HLeithner HLeithner - merge - 12 May 2020
avatar HLeithner
HLeithner - comment - 12 May 2020

Thanks, I missed this but doesn't change the fact that it's strange for an enduser to see the ISO code instead of the givenname.

avatar infograf768
infograf768 - comment - 12 May 2020

We already use the tag in many places. It is also the case for Associations and was improved in J4.

Main reason is always the available space and also a necessary Refactoring to choose or not the Native language name or its English name, both which would not obvioulsy be translatable in the other languages.
The only neutral ways is the flag or the lang tag. And you know how much some fight against the flag...

Add a Comment

Login with GitHub to post a comment