[#28991] - [4.0][com_users] - fix param type onUserAfterSave
- Fixed in Code Base
- 17 May 2020
- Medium
- Build: 4.0-dev
- # 28991
- Diff
- alikon:patch-112
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28984 .
Summary of Changes
pass the 4th param type as a string
Testing Instructions
- Enable users registration (Back-end > Users > Options > Allow User Registration: yes)
- Go to frontend and create a new user but do not open the mail to confirm the new account
- Return to back-end and go to Users panel.
- Try to Activate the new user
or try block / unblock an already registered user
Expected result
able to activate , block / unblock a user from backend without errors
Actual result
Error
Argument 4 passed to PlgUserToken::onUserAfterSave() must be of the type string, null given,
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
| Title |
|
||||||
I have tested this item
The user is activated with no error message. I noticed that without the patch the User is activated despite the error message. The list shows Enabled but the drop-down uses Block/Unblock - is that a terminology problem.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28991.
I don't mind us trying. But we have to be careful. In this case to me an error probably should be null if there hasn't been an error. So changing the typehint to ?string $error in the plugin makes more sense to me than this
| Labels |
Added:
?
|
||
| Category | Administration com_users | ⇒ | Administration com_users Front End Plugins |
i hope i've correctly understood ...please re-check and re-test carefully
I have tested this item
Works!
User activated without errors
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28991.
I have tested this item
With PR apply I've not the error.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28991.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28991.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-17 23:01:51 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Existing plugin events are not safe to typehint. @wilsonge will have to decide if we really want to do this at this point.