NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
7 May 2020

Pull Request for Issue #28895

Summary of Changes

Update node-sass so NodeJS 14.x users can run build tasks

avatar C-Lodder C-Lodder - open - 7 May 2020
avatar C-Lodder C-Lodder - change - 7 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2020
Category NPM Change
avatar richard67
richard67 - comment - 7 May 2020

@jwaisner As you were able to reproduce the issue, could you test this PR?

avatar C-Lodder
C-Lodder - comment - 7 May 2020

@richard67 really doesn't need a human test to be honest. Just updating a dependency.

You can see the table here for NodeJS support: https://www.npmjs.com/package/node-sass

avatar richard67
richard67 - comment - 7 May 2020

@C-Lodder Any reason for the version downgrade of ansi-regex from 3.0.0 to 2.1.1?

https://github.com/joomla/joomla-cms/pull/28989/files#diff-32607347f8126e6534ebc7ebaec4853dL1723-R1725

avatar C-Lodder
C-Lodder - comment - 7 May 2020

@richard67 Maybe a sub-dependency has to revert to an older version. Not sure. Either way, this was the result of running npm i and I can now compile CSS on NodeJS 14.x without any errors.

avatar richard67
richard67 - comment - 7 May 2020

I can now compile CSS on NodeJS 14.x without any errors.

@C-Lodder Didn't have a doubt on it. Was just curious when I saw it.

avatar 810 810 - test_item - 8 May 2020 - Tested successfully
avatar 810
810 - comment - 8 May 2020

I have tested this item successfully on fd2e76e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28989.

avatar wilsonge wilsonge - change - 8 May 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-08 22:36:58
Closed_By wilsonge
Labels Added: NPM Resource Changed ?
avatar wilsonge wilsonge - close - 8 May 2020
avatar wilsonge wilsonge - merge - 8 May 2020
avatar wilsonge
wilsonge - comment - 8 May 2020

Thanks!

Add a Comment

Login with GitHub to post a comment