? ? ? Pending

User tests: Successful: Unsuccessful:

avatar coolcat-creations
coolcat-creations
6 May 2020

Pull Request for Issue #25916

Summary of Changes

Added Template Code Quickicon
Changed Language Keys of Template Style Icon
Added Language Keys for Template Code

Testing Instructions

Apply the patch
Activate the Quick Icon in the module settings
Click the Template Code Link to see if you end up where you should

avatar coolcat-creations coolcat-creations - open - 6 May 2020
avatar coolcat-creations coolcat-creations - change - 6 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2020
Category Administration Language & Strings Modules Templates (admin)
avatar coolcat-creations coolcat-creations - change - 6 May 2020
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2020
Category Administration Language & Strings Modules Templates (admin) Administration Language & Strings Modules
avatar brianteeman
brianteeman - comment - 6 May 2020

Personally I am not in favour of this.

  1. You are not likely to need to do this on a regular basis. If we add this then why not add quickicons for everything (joke but I hope you see my point)
  2. I still prefer the idea of a unified list for the template and the template styles
avatar coolcat-creations
coolcat-creations - comment - 6 May 2020

Personally I am not in favour of this.

1. You are not likely to need to do this on a regular basis. If we add this then why not add quickicons for everything (joke but I hope you see my point)

yes I agree on what you say - still this was a user request and I added it... If more people want to have this it can be easily merged. More flexible would be to just let the user add own quick icons by any way, no idea how. Maybe a subform?

2. I still prefer the idea of a unified list for the template and the template styles

Yes I'd like that too, but no idea how to solve it.

avatar brianteeman
brianteeman - comment - 6 May 2020
  1. I still prefer the idea of a unified list for the template and the template styles
    Yes I'd like that too, but no idea how to solve it.

Not that hard I just dont have the time at the moment

avatar ciar4n
ciar4n - comment - 6 May 2020

Imo one of joomlas strongest features is overidable views. It seems to be often overlooked by users. Something like this might help to resolve this.

avatar coolcat-creations coolcat-creations - change - 7 May 2020
Title
Add Shortcut to Template Code
[4.0] Quickicons - Add Shortcut to Template Code
avatar coolcat-creations coolcat-creations - edited - 7 May 2020
avatar roland-d roland-d - test_item - 11 May 2020 - Tested successfully
avatar roland-d
roland-d - comment - 11 May 2020

I have tested this item successfully on 4deddea

I have tested this patch successfully by applying the patch. The test instructions were not so clear but what I did was, apply the patch and then go to the Modules and filtered on Quick Icons type. Then open the System module. At the bottom you find the new setting Templates Code. Enable the option and click on Save & Close. After that go to the Dashboard and in the top right corner you will see the System module with the link to the Templates code.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28977.

avatar Johanv74 Johanv74 - test_item - 11 May 2020 - Tested successfully
avatar Johanv74
Johanv74 - comment - 11 May 2020

I have tested this item successfully on 4deddea

Together with other JUG040 members and Roland Dalmulder we tested this patch with succes.
I tested it on my own Joomla! 4 installation.
We tested this patch successfully :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28977.

avatar alikon alikon - change - 11 May 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 11 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28977.

avatar zero-24
zero-24 - comment - 20 May 2020

LGTM thanks @coolcat-creations

avatar zero-24 zero-24 - change - 20 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-20 12:03:11
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 20 May 2020
avatar zero-24 zero-24 - merge - 20 May 2020

Add a Comment

Login with GitHub to post a comment