? ? Pending

User tests: Successful: Unsuccessful:

avatar coolcat-creations
coolcat-creations
6 May 2020

Summary of Changes

this PR removes additional padding in content which lets some elements appear misaligned...

Testing Instructions

Apply the patch
npm run build:css
See if I broke something else :-)

Expected result

grafik

Actual result

grafik

cc @HLeithner who reported the issue to me

avatar coolcat-creations coolcat-creations - open - 6 May 2020
avatar coolcat-creations coolcat-creations - change - 6 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2020
Category Administration Templates (admin)
avatar coolcat-creations coolcat-creations - change - 6 May 2020
The description was changed
avatar coolcat-creations coolcat-creations - edited - 6 May 2020
avatar Quy
Quy - comment - 7 May 2020

No padding in home dashboard.

home-dashboard

avatar Quy
Quy - comment - 7 May 2020

I am ok with the original padding to give some breathing room and not be so cramped.

avatar coolcat-creations
coolcat-creations - comment - 8 May 2020

I am ok with the original padding to give some breathing room and not be so cramped.

I do agree that space is often important but here we can make the interface more solid when removing the space. However on Dashboards the space could remain. I'll fix that.

avatar HLeithner
HLeithner - comment - 8 May 2020

Please check global configuration too, there is a submenu which looks wired with padding didn't checked it with this pr (sorry).

avatar coolcat-creations
coolcat-creations - comment - 10 May 2020

I fixed the padding top on cpanels please retest :-)

avatar Quy
Quy - comment - 13 May 2020

@coolcat-creations No changes submitted.

avatar brianteeman
brianteeman - comment - 23 May 2020

@coolcat-creations did you miss the comment from @Quy - looks like you forgot to push your last changes

avatar coolcat-creations coolcat-creations - change - 26 May 2020
Labels Added: ? ?
avatar coolcat-creations
coolcat-creations - comment - 26 May 2020

@Quy @brianteeman Pushed again does it work now?
grafik

avatar brianteeman brianteeman - test_item - 26 May 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 May 2020

I have tested this item successfully on 1a19fde


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28975.

avatar Quy Quy - test_item - 26 May 2020 - Tested successfully
avatar Quy
Quy - comment - 26 May 2020

I have tested this item successfully on 1a19fde


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28975.

avatar Quy Quy - change - 26 May 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28975.

avatar HLeithner HLeithner - change - 26 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-26 22:37:11
Closed_By HLeithner
Labels Added: ?
Removed: ?
avatar HLeithner HLeithner - close - 26 May 2020
avatar HLeithner HLeithner - merge - 26 May 2020
avatar HLeithner
HLeithner - comment - 26 May 2020

Thanks

Add a Comment

Login with GitHub to post a comment