[#28946] - [4.0] Fix Language Override filtering
- Fixed in Code Base
- 6 May 2020
- Medium
- Build: 4.0-dev
- # 28946
- Diff
- SharkyKZ:j4/error/language-overrides
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fixes #28945.
Summary of Changes
Corrects arguments.
Testing Instructions
Create a language override containing <script> tags.
Expected result
No errors and <script> tag stripped out.
Actual result
Argument 1 passed to Joomla\Filter\InputFilter::__construct() must be of the type array, null given, called in libraries\src\Filter\InputFilter.php on line 55
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages |
| Labels |
Added:
?
|
||
| Rel_Number | 0 | ⇒ | 28945 |
| Relation Type | ⇒ | Pull Request for |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28946.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28946.
The code is just the change from JFilterInput to namespaced InputFilter, the paremetrs 1 are replaced by the constants, and the bug fix is to use empty array instead of null for the first 2 parameters. In principle it's the same change as done here for the SafehtmlFilter: https://github.com/joomla/joomla-cms/pull/28660/files#diff-6bd82f43de99f05cfdc86d25c2e10aac
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-06 11:42:55 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks, works as described.
I have tested this item✅ successfully on 8db580c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28946.