? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
4 May 2020

Pull Request for Issue # .

Summary of Changes

Moves component-specific field class out of com_menus and into respective components.
Also corrects class/filename casing.

Testing Instructions

Create administrator menu without preset.

Go to create a new menu item.

Select Categories -> Create New Category and Categories -> List All Categories menu item types. In their forms check that Choose a Component dropdown appears.

Select Fields -> List All Field Groups, Fields -> List All Fields and Workflows -> List All Workflows menu item types. In their forms check that Context dropdown appears.

Expected result

Works like before.

Documentation Changes Required

IDK.

avatar SharkyKZ SharkyKZ - open - 4 May 2020
avatar SharkyKZ SharkyKZ - change - 4 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2020
Category Administration com_categories com_fields com_workflow
avatar SharkyKZ SharkyKZ - change - 4 May 2020
Labels Added: ?
avatar ceford
ceford - comment - 5 May 2020

I could not test this patch because I could not find the items mentioned in the test instructions. I created an empty menu and then a New menu item. But there is no Categories -> Create New Category link and I could not find anything similar. Please provide more specific instructions. I am using the Joomla 4 Patch Tester.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28931.

avatar SharkyKZ
SharkyKZ - comment - 5 May 2020

@ceford You have to create a menu for administrator, not for site. To do that, click Menus -> Manage. And then select Administrator in the dropdown.

avatar ceford
ceford - comment - 5 May 2020

Tested with the following snag: the Fields -> List All Field Groups and Fields -> List All Fields items in the Menu Items list do not actually appear in the Test menu I created. Is that a bug here or a menu bug?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28931.

avatar SharkyKZ
SharkyKZ - comment - 5 May 2020

I'm not sure. But for the test you don't need to create menu items. Only open the menu item form, select correct menu item type and check that the mentioned fields appear, e.g. like this context field:

Screenshot_2020-05-05 Menus New Item - Joomla - Administration

avatar ceford ceford - test_item - 5 May 2020 - Tested successfully
avatar ceford
ceford - comment - 5 May 2020

I have tested this item successfully on d920fed

It does do what the test criteria say it should do.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28931.

avatar toivo toivo - test_item - 15 May 2020 - Tested successfully
avatar toivo
toivo - comment - 15 May 2020

I have tested this item successfully on d920fed

Tested successfully in Nightly Build of 15 May


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28931.

avatar SharkyKZ SharkyKZ - change - 15 May 2020
Status Pending Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 15 May 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28931.

avatar wilsonge wilsonge - change - 25 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-25 17:29:30
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 25 May 2020
avatar wilsonge wilsonge - merge - 25 May 2020
avatar wilsonge
wilsonge - comment - 25 May 2020

Thanks!

Add a Comment

Login with GitHub to post a comment