? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 May 2020

PR for #28904

This is a test PR for the TH alignment issue with safari. It is a bug in bootstrap that they have fixed and merged but not released yet. See twbs/bootstrap#30323

This PR adds a temporary reboot.css override with the code direct from bootstrap. I can't see any other way to fix this beta blocker.

I do not have access to Safari to test this.

@nikosdion please can you test this

avatar brianteeman brianteeman - open - 3 May 2020
avatar brianteeman brianteeman - change - 3 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2020
Category Administration Templates (admin)
avatar infograf768
infograf768 - comment - 4 May 2020

This works fine
Screen Shot 2020-05-04 at 08 55 37

avatar brianteeman brianteeman - change - 4 May 2020
Labels Added: ?
avatar adj9 adj9 - test_item - 4 May 2020 - Not tested
avatar adj9
adj9 - comment - 4 May 2020

I have not tested this item.

In the menu items I found some object centered. I'll put the scran of HTML:
Schermata 2020-05-04 alle 11 24 37

Are you interested in knowing if there are other centered todays?

Software Requirements

  • Safari 13.0.5
  • macOS Catalina 10.15.3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28921.
avatar infograf768
infograf768 - comment - 4 May 2020

@adj9

This PR requires using npm

avatar infograf768
infograf768 - comment - 4 May 2020

I have tested this item successfully on 1a88cf3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28921.

avatar infograf768 infograf768 - test_item - 4 May 2020 - Tested successfully
avatar nikosdion nikosdion - test_item - 4 May 2020 - Tested successfully
avatar nikosdion
nikosdion - comment - 4 May 2020

I have tested this item successfully on 1a88cf3

Yes, that worked perfectly. Thank you, Brian!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28921.

avatar infograf768 infograf768 - change - 4 May 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 4 May 2020

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28921.

avatar infograf768
infograf768 - comment - 4 May 2020

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28921.

avatar infograf768 infograf768 - close - 4 May 2020
avatar infograf768 infograf768 - merge - 4 May 2020
avatar infograf768 infograf768 - change - 4 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-04 10:18:53
Closed_By infograf768
Labels Added: ?
avatar infograf768
infograf768 - comment - 4 May 2020

tks

avatar brianteeman
brianteeman - comment - 4 May 2020

Thanks for testing and merging

Add a Comment

Login with GitHub to post a comment