[#28916] - [4.0] Add extension name/id to uninstall message if extension is locked
- Closed
- 4 May 2020
- Medium
- Build: 4.0-dev
- # 28916
- Diff
- ReLater:patch-1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Change lang string COM_INSTALLER_UNINSTALL_ERROR_LOCKED_EXTENSION
- Use sprintf to display extension name and id
Testing Instructions
- 4.0 nightly build of today (Sunday, 03 May 2020 02:00:34 UTC)
- Go to extensions manager (
administrator/index.php?option=com_installer&view=manage) - Select many locked extensions.
- Click
Uninstall.
Actual result
After applying pr
Additional comment:
- I can't test changes in
libraries/src/Console/ExtensionRemoveCommand.phpin my current environment.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Labels |
Added:
?
?
|
||
| Category | Administration Language & Strings | ⇒ | Administration Language & Strings Libraries |
| Category | Administration Language & Strings Libraries | ⇒ | Administration com_installer Language & Strings Libraries |
if you change to variables please number them. That helps TT when multiple variables.
I have tested this item
Confirm Actual result.
Confirm After Patch, see screenshot, but I don't know what to do with sprintf
Installed: 4.0 nightly build of today (Sunday, 03 May 2020 02:00:34 UTC)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28916. 
I think if you just use Text::_($row->name) instead of $row->name it should work.
I've tested that before I posted pr. You would have to load all relevant language files first. Complete overhead for this little feature.
That's the reason why I've added the ID.
Last change was just a small language string change, so previous test result is still valid.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28916.
but I don't know what to do with sprintf
Ignore that comment below headline "Summary of Changes". It's just an abstract of what I've done in codes. "Code uses sprintf now."
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28916.
if you change to variables please number them. That helps TT when multiple variables.
Sorry. I don't understand that comment.
What he means is that instead of having
The extension %s which is a %s cannot be found
You have
The extension %1s which is a %2s cannot be found
This makes it easier for translators where the order of parts is not the same
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28916.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending. One more test needed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28916.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28916.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28916.
This gives
Would'nt it be better to get
String
COM_INSTALLER_UNINSTALL_ERROR_LOCKED_EXTENSION="The \"%1s\" (ID %2s) is a locked extension and cannot be uninstalled."
What do you think?
Hmm ... either leave the The at the beginning, so it is COM_INSTALLER_UNINSTALL_ERROR_LOCKED_EXTENSION="\"%1s\" (ID %2s) is a locked extension and cannot be uninstalled."
Or change to COM_INSTALLER_UNINSTALL_ERROR_LOCKED_EXTENSION="The extension \"%1s\" (ID %2s) is locked and cannot be uninstalled."
OK for 2nd proposal. It's definitely better phrasing than the existing one.
Ah, come on! Feel free to take over.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-04 11:04:25 |
| Closed_By | ⇒ | ReLater |
@ReLater Please, restore your branch and do that little change:
COM_INSTALLER_UNINSTALL_ERROR_LOCKED_EXTENSION="The extension \"%1s\" (ID %2s) is locked and cannot be uninstalled."
If you really don't want, restore at least the branch so that I can pick your commit, then you will still be counted as co-author in a new PR.
@ReLater Could you translate the extension names in the messages? I think if you just use
Text::_($row->name)instead of$row->nameit should work. Then you could change your language sting to "Locked extensions cannot be uninstalled: Extension name %s, ID %s.", and people would see it is the name which they can see e.g. in "Extensions: Manage".