Feeling Lucky
?
[#28908] - [4.0] sidebar height
- Fixed in Code Base
- 2 May 2020
- Medium
- Build: 4.0-dev
- # 28908
- Diff
- brianteeman:nik-test
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
On a page that is pretty empty the sidebar does not extend the full height of the screen. This is because there is a missing space in the height calculation
min-height: calc(100vh -69px);
That is invalid because the browser thinks its an invalid property value
This pr puts the space back and then the browser can do the calculation
(Maybe this is browser dependent but it definitely is reproducible on chrome for windows)
before
after
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-02 16:59:53 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 2 May 2020
Merged on review. Thanks!
brianteeman
- comment
- 2 May 2020
thanks
I have tested this item✅ successfully on b61c6ba
I can't reproduce the issue because both Firefox 75.0 64 bit for Windows and Chrome 81.0 64 bit for Windows add the missing space here.
But it's clear the space is missing, see e.g. here: https://developer.mozilla.org/en-US/docs/Web/CSS/calc#Expressions.
So from me a good test by code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28908.