[#28902] - Drop index if exists.
- Fixed in Code Base
- 3 May 2020
- Medium
- Build: staging
- # 28902
- Diff
- twister65:3.9.16-index
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Add the parameter IF EXISTS after DROP INDEX.
Testing Instructions
Update Joomla! from version 3.9.15 or older.
Expected result
No error.
Actual result
The update with postgresql throws an error.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Postgresql SQL Administration com_admin |
@twister65 Your PR looks right to me, and I've just checked that the database checker can handle the "IF EXISTS" for the index. But I can't reproduce the issue without your PR. Just updated a 3.9.15 to 3.9.18 using PostgreSQL 10, and I did not get any SQL error in the logfile or the UI. Can it depend on server settings if I get an error or not? Or does the problem only happen for certain versions, or installations with a certain update history?
I have tested this item
I couldn't reproduce the issue with updating a 3.9.15 to 3.9.18, but this may depend on the update history of a particular installation.
The change in this PR is correct and makes updating more safe, and I've verified that the database schema checker can handle "DROP INDEX IF EXISTS" for PostgreSQL.
For testing the update with this PR applied I've used the custom update URL for the update package built for this PR by drone.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28902.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28902.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28902.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-03 08:14:52 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
Hint for testers: For testing this PR you can use the update package built for this PR by our checkin tools (Drone). You can find update packages and at the bottom a cutom update URL at following page: https://ci.joomla.org/artifacts/joomla/joomla-cms/staging/28902/downloads/31730/.