Summary of Changes

When you do something like:

$articleModel = new \Joomla\Component\Content\Administrator\Model\ArticleModel;

$articles = [
  [
    'id' => 0,
    'title' => 'bla',
    'alias' => 'bla'
    'catid' => 1,
    'ordering' => 1
  ],
  [
    'id' => 0,
    'title' => 'foobar',
    'alias' => 'foobar',
    'catid' => 1,
    'ordering' => 2
  ]
];

foreach ($articles as $article)
{
  $articleModel->save($article);

  var_dump($articleModel->getState($articleModel->getName() . '.new'));
}

You will get:

true
false

Because giving the save method directly the ID does create a new article but does not reset the internal ID state in the model. So e.g. plugins which rely on this $isNew get the wrong information.

This happens e.g. heavily in the sample data plugin: https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/sampledata/blog/blog.php#L220-L298 So plugins which hear on "onContentAfterSave" could act the wrong way.

Testing Instructions

1. Install a clean Joomla
2. Go to https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/sampledata/blog/blog.php#L295
3. Add var_dump($articleModel->getState($articleModel->getName() . '.new'));
4. Open browser developer console
5. Execute sample data installation

(Adding this test/debug code will break the installation of the sample datas, but that's ok, as we're testing a specific part and not the whole sample data)

Expected result

bool(true)
bool(true)
bool(true)
bool(true)
bool(true)
bool(true)

Actual result

bool(true)
bool(false)
bool(false)
bool(false)
bool(false)
bool(false)