? ? Pending
Pull Request for # 26639

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
1 May 2020

Pull Request for Issue #26639.

Summary of Changes

Adds client-side validation to toolbar buttons added using Joomla\CMS\Toolbar\ToolbarHelper.
Also removes broken $group argument.

Testing Instructions

Go to Users.
Click New.
Without entering anything in the form click Save.

Expected result

Form is not submitted, required fields are highlighted and message is shown:

The form cannot be submitted as it's missing required data.
Please correct the marked fields and try again.

Actual result

Form is submitted but saving fails with warning:

Field required: Name
Field required: Login Name (Username)
Field required: Email

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 1 May 2020
avatar SharkyKZ SharkyKZ - change - 1 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2020
Category Libraries
avatar SharkyKZ SharkyKZ - change - 1 May 2020
Rel_Number 26639
Relation Type Pull Request for
Labels Added: ?
avatar ChristineWk
ChristineWk - comment - 1 May 2020

I have tested this item successfully on ca7939f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28897.

avatar ChristineWk ChristineWk - test_item - 1 May 2020 - Tested successfully
avatar Quy
Quy - comment - 1 May 2020

I have tested this item successfully on ca7939f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28897.

avatar Quy Quy - test_item - 1 May 2020 - Tested successfully
avatar Quy Quy - change - 1 May 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 1 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28897.

avatar wilsonge wilsonge - close - 2 May 2020
avatar wilsonge wilsonge - merge - 2 May 2020
avatar wilsonge wilsonge - change - 2 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-02 16:58:56
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 2 May 2020

Thanks! Nice piece of debugging on the issue!

Add a Comment

Login with GitHub to post a comment