[#28897] - [4.0] Client-side validation not triggered when submitting some forms
- Fixed in Code Base
- 2 May 2020
- Medium
- Build: 4.0-dev
- # 28897
- Diff
- SharkyKZ:j4/toolbar/validation
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26639.
Summary of Changes
Adds client-side validation to toolbar buttons added using Joomla\CMS\Toolbar\ToolbarHelper.
Also removes broken $group argument.
Testing Instructions
Go to Users.
Click New.
Without entering anything in the form click Save.
Expected result
Form is not submitted, required fields are highlighted and message is shown:
The form cannot be submitted as it's missing required data.
Please correct the marked fields and try again.
Actual result
Form is submitted but saving fails with warning:
Field required: Name
Field required: Login Name (Username)
Field required: Email
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Rel_Number | ⇒ | 26639 | |
| Relation Type | ⇒ | Pull Request for | |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28897.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28897.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-02 16:58:56 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks! Nice piece of debugging on the issue!
I have tested this item✅ successfully on ca7939f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28897.