? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
30 Apr 2020

Pull Request for Issue #28789

Summary of Changes

[AppVeyor] Try to fix appveryor builds as mention here: #28789 (comment)

avatar zero-24 zero-24 - open - 30 Apr 2020
avatar zero-24 zero-24 - change - 30 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2020
Category Unit Tests
avatar zero-24 zero-24 - change - 30 Apr 2020
Labels Added: ? ?
avatar zero-24
zero-24 - comment - 30 Apr 2020

Any pointers on this one where to look at @rdeutz @SniperSister or should we just drop php 7.2+ testing as it is not supported by our tooling? Would not good to me.

avatar wilsonge
wilsonge - comment - 30 Apr 2020

The only thing that doesn't support it is the friendsofphp/php-cs-fixer - I'm not even sure if we use this anywhere - I think it was just a nice to have automated fixer?

I'd be tempted to just drop it in staging if we aren't using it actively

avatar zero-24
zero-24 - comment - 1 May 2020

I'd be tempted to just drop it in staging if we aren't using it actively

hmm agree but seems our lock file is out of date and needs to be updated anyway right? Or I'm just looking at the wrong place?

avatar wilsonge
wilsonge - comment - 1 May 2020

why is it out of date?

avatar zero-24
zero-24 - comment - 1 May 2020

when i remove the line mention and run composer i get this:
image

avatar wilsonge
wilsonge - comment - 1 May 2020

That means you've made changes locally to the files in the directory on your laptop

avatar zero-24
zero-24 - comment - 1 May 2020

Well I just have to run composer remove on the mention package right?

That thing than result into a tone of changed files. Maybe i'm doing something wrong?

avatar mbabker
mbabker - comment - 6 May 2020

Here's my free advice for the day. Check the Composer version that AppVeyor is installing, the error message being printed comes from a feature in Composer 2.0.

Working around that addresses the most immediate error, but it still doesn't address the fact that the CMS dependency tree is reliant on a number of end of support versions of software packages and with PHP 8 approaching you might find yourselves forking and maintaining packages to try and be compatible with the 10 PHP branches the version constraint will allow (5.3.10 thru 8.0).

avatar zero-24 zero-24 - change - 10 May 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-05-10 21:56:48
Closed_By zero-24
Labels Added: ?
Removed: ?
avatar zero-24 zero-24 - close - 10 May 2020
avatar wilsonge
wilsonge - comment - 11 May 2020

3687dba Based on @mbabker 's comment fixed

Add a Comment

Login with GitHub to post a comment