User tests: Successful: Unsuccessful:
Pull Request for Issue #28879 .
With Pull Request (PR) #28834 , setting the Bootstrap class for the counters in file build/media_source/com_cpanel/js/admin-system-loader.es6.js
has been adapted to Bootstrap 4 class "float-right", so these counters are pulled to the right side when LTR and to the left side when RTL.
But the check marks shown wenn all is ok and no counter is shown, or the danger icons shown when something went wrong with the check, those have never been handled in that way in that js.
This mix of alignment looks ugly when direction is LTR, see screenshot in section "Actual result" below. For RTL the other icons beside the counters are already floating to the left.
This PR here fixes this by adding the "float-right" class to the span initially in PHP.
Check the system dashboard in Atum.
Result: See section "Actual result" below.
Apply the patch of this PR.
Check again the system dashboard in Atum (refresh page before).
Result: See section "Expected result" below.
RTL: See expected result.
None, except if we have some documentation telling our backend has to look ugly ;-) (joking).
What is interesting: For RTL the other icons beside the counters are already floating to the left. I think the reason is this section in Atum's template-rtl.scss, but I am not sure:
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/template-rtl.scss#L167-L171. So we might have duplicate css in case of RTL, which can be simplified. But this is not scope of this PR here.
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
RTC
The spinner should also be right-aligned so add the class directly to https://github.com/richard67/joomla-cms/blob/3029198c64088286144607c90550e34036210224/administrator/modules/mod_submenu/tmpl/default.php#L68 instead of adding it on the fly.
Will try tomorrow (Friday)
Labels |
Added:
?
|
Category | JavaScript Repository NPM Change | ⇒ | Modules Administration |
Thanks @Quy for the hint. I've changed as you proposed.
@brianteeman @alikon Sorry for having wasted your time for the 1st test. Spinner is fixed now, too. I'd be happy if you could test again. Thanks in advance.
Status | Ready to Commit | ⇒ | Pending |
Trying again to fix labels consistentcy between issue tracker and GitHub.
Not RTC, bloody bot.
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-02 05:40:51 |
Closed_By | ⇒ | infograf768 |
tks
I have tested this item✅ successfully on 3029198
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28882.