? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
30 Apr 2020

Pull Request for Issue #28879 .

Summary of Changes

With Pull Request (PR) #28834 , setting the Bootstrap class for the counters in file build/media_source/com_cpanel/js/admin-system-loader.es6.js has been adapted to Bootstrap 4 class "float-right", so these counters are pulled to the right side when LTR and to the left side when RTL.

But the check marks shown wenn all is ok and no counter is shown, or the danger icons shown when something went wrong with the check, those have never been handled in that way in that js.

This mix of alignment looks ugly when direction is LTR, see screenshot in section "Actual result" below. For RTL the other icons beside the counters are already floating to the left.

This PR here fixes this by adding the "float-right" class to the span initially in PHP.

Testing Instructions

  1. Check the system dashboard in Atum.
    Result: See section "Actual result" below.

  2. Apply the patch of this PR.

  3. Check again the system dashboard in Atum (refresh page before).
    Result: See section "Expected result" below.

Expected result

LTR:
j4-system-dashboard-checks-right

RTL:
j4-system-dashboard-checks-right_RTL

Actual result

LTR:
j4-system-dashboard-current

RTL: See expected result.

Documentation Changes Required

None, except if we have some documentation telling our backend has to look ugly ;-) (joking).

Additional information

What is interesting: For RTL the other icons beside the counters are already floating to the left. I think the reason is this section in Atum's template-rtl.scss, but I am not sure:
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/template-rtl.scss#L167-L171. So we might have duplicate css in case of RTL, which can be simplified. But this is not scope of this PR here.

avatar richard67 richard67 - open - 30 Apr 2020
avatar richard67 richard67 - change - 30 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2020
Category JavaScript Repository NPM Change
avatar richard67 richard67 - change - 30 Apr 2020
The description was changed
avatar richard67 richard67 - edited - 30 Apr 2020
avatar richard67 richard67 - change - 30 Apr 2020
The description was changed
avatar richard67 richard67 - edited - 30 Apr 2020
avatar richard67 richard67 - change - 30 Apr 2020
The description was changed
avatar richard67 richard67 - edited - 30 Apr 2020
avatar brianteeman
brianteeman - comment - 30 Apr 2020

I have tested this item successfully on 3029198


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28882.

avatar brianteeman brianteeman - test_item - 30 Apr 2020 - Tested successfully
avatar alikon
alikon - comment - 30 Apr 2020

I have tested this item successfully on 3029198


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28882.

avatar alikon alikon - test_item - 30 Apr 2020 - Tested successfully
avatar alikon alikon - change - 30 Apr 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 30 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28882.

avatar alikon
alikon - comment - 30 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28882.

avatar Quy
Quy - comment - 30 Apr 2020

The spinner should also be right-aligned so add the class directly to https://github.com/richard67/joomla-cms/blob/3029198c64088286144607c90550e34036210224/administrator/modules/mod_submenu/tmpl/default.php#L68 instead of adding it on the fly.

avatar richard67
richard67 - comment - 30 Apr 2020

Will try tomorrow (Friday)

avatar richard67 richard67 - change - 1 May 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2020
Category JavaScript Repository NPM Change Modules Administration
avatar richard67
richard67 - comment - 1 May 2020

Thanks @Quy for the hint. I've changed as you proposed.

@brianteeman @alikon Sorry for having wasted your time for the 1st test. Spinner is fixed now, too. I'd be happy if you could test again. Thanks in advance.

avatar richard67 richard67 - change - 1 May 2020
The description was changed
avatar richard67 richard67 - edited - 1 May 2020
avatar richard67 richard67 - change - 1 May 2020
Status Ready to Commit Pending
avatar richard67 richard67 - alter_testresult - 1 May 2020 - alikon: Not tested
avatar richard67 richard67 - alter_testresult - 1 May 2020 - brianteeman: Not tested
avatar richard67
richard67 - comment - 1 May 2020

Trying again to fix labels consistentcy between issue tracker and GitHub.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28882.

avatar richard67
richard67 - comment - 1 May 2020

Not RTC, bloody bot.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28882.

avatar richard67 richard67 - change - 1 May 2020
The description was changed
avatar richard67 richard67 - edited - 1 May 2020
avatar Quy
Quy - comment - 1 May 2020

I have tested this item successfully on 3029198


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28882.

avatar Quy Quy - test_item - 1 May 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 2 May 2020

I have tested this item successfully on 3029198


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28882.

avatar infograf768 infograf768 - test_item - 2 May 2020 - Tested successfully
avatar infograf768 infograf768 - change - 2 May 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 2 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28882.

avatar infograf768 infograf768 - close - 2 May 2020
avatar infograf768 infograf768 - merge - 2 May 2020
avatar infograf768 infograf768 - change - 2 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-02 05:40:51
Closed_By infograf768
avatar infograf768
infograf768 - comment - 2 May 2020

tks

Add a Comment

Login with GitHub to post a comment