Labels |
Added:
?
?
|
I agree with the float right for all of it.
and evidently left for RTL
Sure.
@C-Lodder Possibly you can advise: I've found a solution for this issue here which looks as follows (left side my change, right side 4.0-dev):
.
See also diff on GitHub between my branch for a new PR and 4.0-dev:4.0-dev...richard67:4.0-dev-syspanel-check-marks-float-right.
The disadvantage of this solution is that during the (normally short) time while the check is running and the spinner icon is shown, that spinner is not pulled to the right. After that, when ready, any error or result or check mark is then pulled to the right (LTR) or to the left (RTL) with the bootstrap css-class "float-right".
Of course I could set that css class "float-right" in PHP in the layout initially, so also the spinner would have that class, but this would be in the core layout and so cause dependency of 3rd party backend templates to bootstrap. As far as I know we don't want this, and for this little change here I should not create a template override.
So the only way to fix that I see in the way done here, in the template-specific js. But I would have to extend the onBoot function too much for that, so I think the solution shown above is an appropriate compromise.
But if you can make a proposal how to do it better, let me know please.
You don't need to use any floats, just use flexbox. This will also work fine in RTL mode
I'm really not a CSS expert, I only started with that because it looks so ugly to me, and I haven't seen anybody else complaining about it, so I even thought it might be desired design, that's why I've made an RFC issue.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-30 10:47:08 |
Closed_By | ⇒ | richard67 |
They should all float right