? ?
avatar richard67
richard67
29 Apr 2020

Regarding the system dashboard: What do you like more?

Current look

j4-system-dashboard-current

Proposed look

j4-system-dashboard-checks-right

Please vote with comments below.

If people like the proposal and nobody is faster, I’ll make a Pull Request.

avatar richard67 richard67 - open - 29 Apr 2020
avatar joomla-cms-bot joomla-cms-bot - change - 29 Apr 2020
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Apr 2020
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Apr 2020
avatar richard67 richard67 - change - 29 Apr 2020
The description was changed
avatar richard67 richard67 - edited - 29 Apr 2020
avatar brianteeman
brianteeman - comment - 29 Apr 2020

They should all float right

avatar jwaisner
jwaisner - comment - 30 Apr 2020

I agree with the float right for all of it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28879.

avatar infograf768
infograf768 - comment - 30 Apr 2020

and evidently left for RTL

avatar richard67
richard67 - comment - 30 Apr 2020

Sure.

avatar richard67
richard67 - comment - 30 Apr 2020

@C-Lodder Possibly you can advise: I've found a solution for this issue here which looks as follows (left side my change, right side 4.0-dev):
j4-cpanel-quickicons-flow-right.

See also diff on GitHub between my branch for a new PR and 4.0-dev:4.0-dev...richard67:4.0-dev-syspanel-check-marks-float-right.

The disadvantage of this solution is that during the (normally short) time while the check is running and the spinner icon is shown, that spinner is not pulled to the right. After that, when ready, any error or result or check mark is then pulled to the right (LTR) or to the left (RTL) with the bootstrap css-class "float-right".

Of course I could set that css class "float-right" in PHP in the layout initially, so also the spinner would have that class, but this would be in the core layout and so cause dependency of 3rd party backend templates to bootstrap. As far as I know we don't want this, and for this little change here I should not create a template override.

So the only way to fix that I see in the way done here, in the template-specific js. But I would have to extend the onBoot function too much for that, so I think the solution shown above is an appropriate compromise.

But if you can make a proposal how to do it better, let me know please.

avatar C-Lodder
C-Lodder - comment - 30 Apr 2020

You don't need to use any floats, just use flexbox. This will also work fine in RTL mode

avatar richard67
richard67 - comment - 30 Apr 2020

@C-Lodder Hmm, it was using floats before for the counters, I just extended it to the other icons (check marks and danger). For changing that to flexbox you have to advise me. Or do a separate PR later.

avatar richard67
richard67 - comment - 30 Apr 2020

I'm really not a CSS expert, I only started with that because it looks so ugly to me, and I haven't seen anybody else complaining about it, so I even thought it might be desired design, that's why I've made an RFC issue.

avatar richard67
richard67 - comment - 30 Apr 2020

@C-Lodder It's not really a float, its bs class name "float-right" which we handle for RTL in SCSS having the correct float to the left (I hope. Will test later).

avatar richard67
richard67 - comment - 30 Apr 2020

LTR:
j4-system-dashboard-checks-right

RTL:
j4-system-dashboard-checks-right_RTL

avatar richard67
richard67 - comment - 30 Apr 2020

I've meanwhile made a PR. See #28882 .

avatar richard67 richard67 - change - 30 Apr 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-04-30 10:47:08
Closed_By richard67
avatar richard67 richard67 - close - 30 Apr 2020

Add a Comment

Login with GitHub to post a comment