[#28854] - [4.0] Quickicon text for Template styles
- Fixed in Code Base
- 2 May 2020
- Medium
- Build: 4.0-dev
- Easy Test
- # 28854
- Diff
- chmst:quickicon-button-templates
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28851 .
Summary of Changes
Change Button text so that it matches the link to template styles.
Testing Instructions
Code inspect.
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28854.
I have not tested this item.
@Chraneco
Sorry but I didn't understand which text you want to change. Whether it is on the frontend or on the backend.
In the setting of the template (I only have CASSIOPEA) in Advanced I only have title and description.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28854.
@adj9 it is the backend dashboard with quick ions. See it on the dashboard.
The icon templates goes to view template styles (frontend), not to templatesoverview.
The aim of quickicons is to make it easier builing a site. In general, web designers want to do overrides or change params in a template style. (for the frontend).
So the text on the icon "Templates" is confusing, as @coolcat-creations said, as the icon goes to the view "template styles".
This PR makes this clear.
I have tested this item
Reviewed language string change and looks good. Also tested PR and makes proper changes with no issues.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28854.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28854.
Concerning #28854 (comment)
I got no reply...
When things get a bit more stable, I therefore may have to make a specific PR.
@chmst Concerning @infograf768 comment. Is that something you may be able to work with him on to minimize the need for multiple PRs?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-02 10:45:07 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
@infograf768 separate PR sounds good to me - seems logical.
Thanks @chmst !
We could avoid having multiple strings with the same value by using here a JGLOBAL string.
For example it would also be used here:
#28844 (comment)
There may be other quickicons strings concerned by such a modification.