Language Change ? NPM Resource Changed ? Failure

User tests: Successful: 0 Unsuccessful: 0

avatar PhocaCz
PhocaCz
27 Apr 2020

This may not be the right pull request, maybe just an idea. If it is incorrect due to my ignorance of the system, then I apologize.

I just didn't find a way to decrease the font size in the Atum template parameters. Then I found, there is a way to increase the font size in Joomla! 4 Accessibility Settings. The question is, why there is YES/NO option only and why not use this parameter and not add more options? I can imagine, for a lot of people current font size is too large and they want to decrease it. For another group, 18px is not enough (please ignore the fact that this can be done per browser, the parameter just exists so this PR just extends it). Of course, it can be somehow in conflict with another parts of CSS features which I don't know (so in this case, CSS developers should make a statement to this PR).

Summary of Changes

I just added some more values to parameter Increase Font Size, so user will be able to change font size to: 80%, 90%, 110%, 125% (of course, values can be extended).

Increase Font Size

Of course, ideally, the parameter name should also change (from Increase to Increase/Decrease ...)

Testing Instructions

Install the patch and just go to Accessibility Settings and switch the font size. (SCSS file _global.scss was changed - for now I have no information if patch tester is able to compile scss or it needs to be done manually.)

Expected result

You will be able to increase/decrease font size of Atum - backend template.

90%:
90%

125%:
125%

Jan

avatar PhocaCz PhocaCz - open - 27 Apr 2020
avatar brianteeman
brianteeman - comment - 27 Apr 2020

It's a valid accessibility to add a % increase
I can't imagine any accessibility case for decreasing the font size

That's not saying there isnt a case for setting the font size just that accessibility options is not the correct place to set a decrease

avatar coolcat-creations
coolcat-creations - comment - 27 Apr 2020

I agree to the decrease like @brianteeman said - Can we have a value slider or a num field to set the increase, then you would not need to add severall percentages? Or is the dropdown more accessible?

avatar brianteeman
brianteeman - comment - 27 Apr 2020

any of those can be accessible

avatar chmst
chmst - comment - 27 Apr 2020

I can't imagine any accessibility case for decreasing the font size

There is a use case. Unfortunately I cannot describe it in English and dn't have the ophthalmologist vocabulary. There are people who can see only a small area like at the end of a tunnel. They try to make fonts small so that they see more in the small area they can see.

avatar jwaisner jwaisner - change - 27 Apr 2020
Title
Atum - Accessibility - Change Font Size - Why only 18px
[4.0] Atum - Accessibility - Change Font Size - Why only 18px
Status New Confirmed
Build staging 4.0-dev
avatar joomla-cms-bot joomla-cms-bot - edited - 27 Apr 2020
avatar joomla-cms-bot joomla-cms-bot - change - 27 Apr 2020
Category Administration com_users Templates (admin)
avatar PhocaCz
PhocaCz - comment - 27 Apr 2020

I can't imagine any accessibility case for decreasing the font size

I understand but why not use this parameter? Why to add another one (in case, there is a demand for such feature) . You can add new feature (decreasing) with only adding new values to current parameter.

Having smaller font size means for somebody displaying more content on screen (without scrolling, moving, etc).

avatar PhocaCz
PhocaCz - comment - 27 Apr 2020

There is a use case. Unfortunately I cannot describe it in English and dn't have the ophthalmologist vocabulary. There are people who can see only a small area like at the end of a tunnel. They try to make fonts small so that they see more in the small area they can see.

Yes, and I don't think, extending plus values by minus values is something complicated and may bother someone.

avatar coolcat-creations
coolcat-creations - comment - 27 Apr 2020

So what about a num field for percentage input? It's probably most flexible?

avatar PhocaCz
PhocaCz - comment - 27 Apr 2020

So what about a num field for percentage input? It's probably most flexible?

There is a range form field in Joomla! (HTML) but it does not display values:

range

avatar brianteeman
brianteeman - comment - 27 Apr 2020

@chmst valid point

avatar PhocaCz
PhocaCz - comment - 27 Apr 2020

So what about a num field for percentage input? It's probably most flexible?

You can even add own values (text form field), but then you need to completely overwrite this feature, because there is no option to add own values to static CSS file.

avatar C-Lodder
C-Lodder - comment - 27 Apr 2020

I'm a little confused as to why this is a com_users option but the styling is part of the template. Either this option should be moved to the template or the styling should go in a core SCSS file and be imported via the template

avatar coolcat-creations
coolcat-creations - comment - 27 Apr 2020

I'm a little confused as to why this is a com_users option but the styling is part of the template. Either this option should be moved to the template or the styling should go in a core SCSS file and be imported via the template

It's because it's user specific style change for accessibility.

avatar C-Lodder
C-Lodder - comment - 27 Apr 2020

That's fair enough. But then if I install a 3rd party backend template, this setting will most likely not work unless the developer uses the same CSS.

avatar PhocaCz
PhocaCz - comment - 27 Apr 2020

I'm a little confused as to why this is a com_users option but the styling is part of the template. Either this option should be moved to the template or the styling should go in a core SCSS file and be imported via the template

Hmmm, I think, a strategic decision must be made here. Will all accessibility parameters be bound to the template? If yes, parameters should be moved to template. If no, even if it's technically bad (affecting the template by the component), it should stay where it is for now.

avatar coolcat-creations
coolcat-creations - comment - 27 Apr 2020

What about a Template style select in User settings and the possibility to add a new template style easily from there? For this every backend user would need to have the rights to create a new style. It would not be a11y settings but style settings in general but solve the need for customisation? The settings that are there now would have to move to template styles in a seperate tab named accessibility?

avatar SharkyKZ
SharkyKZ - comment - 28 Apr 2020

Any comments on how these settings compare to Accessibility plugin? Do we need both?

avatar PhocaCz
PhocaCz - comment - 28 Apr 2020

Any comments on how these settings compare to Accessibility plugin? Do we need both?

I by myself don't know, the purpose of this PR was just extend current existing parameter "increase font size" by more options (instead of YES/NO)

Why there are two accessibility settings (one core in user profile, second plugin), hard to say.

Accessibility

In fact, if there will be not the core option, this PR does not make any sense more.

avatar carcam
carcam - comment - 29 Apr 2020

We have discussed this at JAT and we think the option to reduce the font size is not needed. The font size is small enough so that the case of people with tunnel vision does not apply here. Also there is a browser mechanism that allows you to freely adjust the font size. Also after checking, this is not required by any success criterion as there is no such requirement in Functional Performance Criteria.

avatar PhocaCz
PhocaCz - comment - 29 Apr 2020

We have discussed this at JAT and we think the option to reduce the font size is not needed. The font size is small enough so that the case of people with tunnel vision does not apply here. Also there is a browser mechanism that allows you to freely adjust the font size. Also after checking, this is not required by any success criterion as there is no such requirement in Functional Performance Criteria.

Does this mean, decreasing text size will even be removed from Accessibility plugin?

avatar brianteeman
brianteeman - comment - 29 Apr 2020

We have discussed this at JAT and we think the option to reduce the font size is not needed. The font size is small enough so that the case of people with tunnel vision does not apply here. Also there is a browser mechanism that allows you to freely adjust the font size. Also after checking, this is not required by any success criterion as there is no such requirement in Functional Performance Criteria.

The accessibility rule is that a user should be able to resize the text. Although it doesnt specifically state decrease in size in the techniques for satisfying the criteria it states a button to increase and decrease. In the additional document Accessibility Requirements for People with Low Vision it does explicitly state the need to reduce the text size.

The font size is small enough so that the case of people with tunnel vision does not apply here

Wow - I didn't know we had medical experts on the JAT - thats an awesome improvement. Seriously I am sure in the cold light of day reading what you wrote again you will realise that was a silly statement.

there is a browser mechanism that allows you to freely adjust the font size

A browser mechanism is not an accepted method for passing any criteria.

avatar richard67
richard67 - comment - 29 Apr 2020

The technical issue mentioned by @C-Lodder also applies to the one font size which can be set right now without this PR, that it's a user setting which is wort nothing if a 3rd party template doesn't support it. This PR here doesn't change that, and it doesn't make anything worse in this aspect.

Regarding accessibility: I am not an accessibility expert, but I don't think that there are rules telling we have to use only a normal and a large size like now, but are not allowed to have more choices like this PR adds with a small and easy code change. And for me it is perfect for accessibility if that can be adjusted on user level. So to me this PR seems to be an improvement.

If there is anything wrong with accessibility settings on user level in J4, then it is wrong with and without this PR.

So I see no reason to block this PR with a discussion which leads far away from what this PR does.

avatar chmst
chmst - comment - 29 Apr 2020

Decreasing font size is not required by WCAG, this is true. And I surely will not decrease font sizes with my old eyes :).

But - why don't we name these settings "Personal settings". We could do here so many things, it must not be for disabled. So everyone could set font size as he/she likes and it does not matter if it is set due to disabilities or personal preferences.

avatar PhocaCz
PhocaCz - comment - 29 Apr 2020

BTW the purpose of this PR/idea is to somehow improve the potential of one parameter. The parameter itself just sets the font size to 18px which is really absurd. If we already have such a parameter, why not use more values. Because parameters are here to allow different settings. Limiting them to only one value does not make sense.

avatar brianteeman
brianteeman - comment - 29 Apr 2020

But - why don't we name these settings "Personal settings".

Removing the words accessibility is fine by me. But if we do that as we already have a tab called basic settings how about either calling it advanced settings or merging the fields into that tab

avatar brianteeman
brianteeman - comment - 29 Apr 2020

Limiting them to only one value does not make sense.

I have no idea why I originally wrote this feature with that font setting - there must have been some document I was following but I don't remember and now it doesn't seem logical

avatar PhocaCz
PhocaCz - comment - 30 Apr 2020

I have no idea why I originally wrote this feature with that font setting - there must have been some document I was following but I don't remember and now it doesn't seem logical

So, if you are the author of the original parameter, you are the only one here who can say:
a) Yes, it can be extended because it does not break the original function
b) or No, it cannot be extended because it breaks the original function

:-)

avatar chmst
chmst - comment - 30 Apr 2020

I like the idea of integrating the accessible settings into the basic settings. And removing the accessibility .. . Some people like monochrome - but not due to a disability. So this seems better "inclusive".

avatar coolcat-creations
coolcat-creations - comment - 30 Apr 2020

So how about having a Template style setting in the User Settings?

avatar SharkyKZ
SharkyKZ - comment - 8 May 2020

So how about having a Template style setting in the User Settings?

There's already an option for that (only for backend though).

avatar SharkyKZ
SharkyKZ - comment - 8 May 2020

If these options are kept, they'll have to be moved to Atum's accompanying plugin.

avatar brianteeman
brianteeman - comment - 8 May 2020

What plugin?

avatar coolcat-creations
coolcat-creations - comment - 8 May 2020

If these options are kept, they'll have to be moved to Atum's accompanying plugin.

Yes you are right, so it would be good to make it more userfriendly to create a personal style and save it directly in the profile. Actually some less clicks than clicking on: system, template styles, copy style, set up, user profile, select style

avatar PhocaCz PhocaCz - change - 1 Oct 2021
Labels Added: ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2021
Category Administration com_users Templates (admin) Administration com_users Templates (admin) NPM Change
avatar PhocaCz PhocaCz - change - 1 Oct 2021
Labels Added: NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2021
Category Administration com_users Templates (admin) NPM Change Administration com_users Templates (admin) NPM Change Front End Templates (site)
avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2021
Category Administration com_users Templates (admin) NPM Change Front End Templates (site) Administration com_users Templates (admin) NPM Change Language & Strings Front End Templates (site)
avatar PhocaCz PhocaCz - change - 1 Oct 2021
Labels Added: Language Change
avatar bembelimen bembelimen - change - 22 Jan 2022
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2022-01-22 09:50:54
Closed_By bembelimen
Labels Added: ?
avatar bembelimen
bembelimen - comment - 22 Jan 2022

Hi @PhocaCz thank you for your idea.

As the branch is deleted and the approach should be a more comprehensive enhancement, I'll close it here.

But probably you could open a discussion here to get something going?

avatar bembelimen bembelimen - close - 22 Jan 2022

Add a Comment

Login with GitHub to post a comment