?
avatar coolcat-creations
coolcat-creations
27 Apr 2020

What needs to be fixed

We have currently in template Atum the different logos:

logo-joomla-white.svg
logo-joomla-blue.svg
logo-blue.svg
logo.svg

  • The logo.svg is defined or used in:
    login.php
    error_full.php
    index.php
    error_login.php

But for examplate it's defined in index.php but not apparently not used there.

  • Then there is the logo-blue.svg which is used in login.php in a different size as in index.php.
    where logo-blue is the Joomla brandmark and logo-joomla-blue.svg is the full logo.

  • The naming ist not logical and the usage of the logos is confusing, The logos need renaming, research where what is used and cleaned up. The names should be more general and contain their usage. For example something like logo-login-form.svg logo-header-collapsed.svg, logo-header-expanded.svg ... and so on. Since they can be coloured they don't have to contain a color name, since they can be changed after a template copy they should not contain "joomla" in it's file name.

  • The usage of a custom logo in the template stile has to be corrected like reported by @micker

  • The size of the svg should be defined in the svg itself and not in the scss like reported by @C-Lodder

I can work on this issue just dropping it in here as an issue to have a worklist-item.

avatar coolcat-creations coolcat-creations - open - 27 Apr 2020
avatar joomla-cms-bot joomla-cms-bot - change - 27 Apr 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 27 Apr 2020
avatar coolcat-creations coolcat-creations - change - 27 Apr 2020
The description was changed
avatar coolcat-creations coolcat-creations - edited - 27 Apr 2020
avatar micker
micker - comment - 27 Apr 2020

hello i test with logo in login screen
image
i think max-height can be set to 2.3rem;
no header changing better alignement with link menu on right

avatar micker
micker - comment - 27 Apr 2020

in menu collapsed and if i use mini logo
image
its better but i think we can center it in heigh and width

avatar micker
micker - comment - 27 Apr 2020

same think in opnned menu, heigher max-height seams better
image

avatar coolcat-creations
coolcat-creations - comment - 27 Apr 2020

in menu collapsed and if i use mini logo
image
its better but i think we can center it in heigh and width

yes I think that the brandmark needs a better alignment too, thank you!

avatar fevangelou
fevangelou - comment - 27 Apr 2020

Since you're at it, the Joomla logo is now visible as "Jooma". The SVG that was produced for the logo is surely not optimal. Here's how it looks on today's build from commit with ID: https://github.com/joomla/joomla-cms/tree/08b27e74737f859c6a873c661df268ca4a7f148b

Screen Shot 2020-04-27 at 18 55 23

avatar fevangelou
fevangelou - comment - 27 Apr 2020

Disregard my previous comment as it was a stuck cached copy showing up from before the update to today's snapshot.

Screen Shot 2020-04-27 at 19 03 38

Still, it could use some really minor spacing between the letters (which would require a different SVG file altogether), if it's to display at such a small size OR it should be bumped from 1.3 to something like 1.8 rems. For example:

Screen Shot 2020-04-27 at 19 06 28

avatar coolcat-creations
coolcat-creations - comment - 27 Apr 2020

@fevangelou Thank you! Well, I will not be able to change the registered Joomla Logo but I'll see how to fix the Dimensions to make it appear better :-)

avatar coolcat-creations coolcat-creations - change - 27 Apr 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-04-27 20:45:05
Closed_By coolcat-creations
avatar coolcat-creations
coolcat-creations - comment - 27 Apr 2020

Closed because of the PR #28839

avatar coolcat-creations coolcat-creations - close - 27 Apr 2020

Add a Comment

Login with GitHub to post a comment