Feeling Lucky
?
?
[#28823] - [4.0] Check if file exists before trying to copy
- Fixed in Code Base
- 2 May 2020
- Medium
- Build: 4.0-dev
- # 28823
- Diff
- Bakual:4_CheckFileBeforeCopy
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Follow up on #28813
Summary of Changes
Just adding a check if the file exists before trying to copy it.
Testing Instructions
Copy a template
Expected result
works
Actual result
works
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
richard67
- comment
- 27 Apr 2020
You could move the $dst = Path::clean($toPath . '/' . $folder . '/' . $languageFile); inside the if (File::exists($src)) ;-)
Bakual
- comment
- 27 Apr 2020
I could, but I prefer it to have like it is so src and dst are right after eachother. Imho it's easier to see what happens.
richard67
- comment
- 27 Apr 2020
I have tested this item
On review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28823.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 27 Apr 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28823.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-02 10:39:22 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
wilsonge
- comment
- 2 May 2020
Thanks!
I have tested this item✅ successfully on 80450cb
On review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28823.