? ? Pending

User tests: Successful: Unsuccessful:

avatar degobbis
degobbis
26 Apr 2020

Summary of Changes

Use renderField frontend com_contig modules view

Testing Instructions

  • go to the com_config modules frontend view (edit module)
  • confirm all is working
  • apply this patch
  • confirm it is still working

Extra test

  • repeat the steps from above on a multilangual site

Expected result

We use renderField and not hardcode the field generation

Actual result

We use a hardcoded field generation

Documentation Changes Required

none

49d56e5 26 Apr 2020 avatar degobbis CS
avatar degobbis degobbis - open - 26 Apr 2020
avatar degobbis degobbis - change - 26 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2020
Category Front End com_config
avatar degobbis degobbis - change - 27 Apr 2020
The description was changed
avatar degobbis degobbis - edited - 27 Apr 2020
avatar zero-24
zero-24 - comment - 1 May 2020

I have tested this item successfully on 49d56e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28817.

avatar zero-24 zero-24 - test_item - 1 May 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 1 May 2020

I have tested this item successfully on 49d56e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28817.

avatar jwaisner jwaisner - test_item - 1 May 2020 - Tested successfully
avatar jwaisner jwaisner - change - 1 May 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 1 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28817.

avatar infograf768 infograf768 - change - 2 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-02 08:25:52
Closed_By infograf768
Labels Added: ? ?
avatar infograf768 infograf768 - close - 2 May 2020
avatar infograf768 infograf768 - merge - 2 May 2020
avatar infograf768
infograf768 - comment - 2 May 2020

tks

avatar infograf768
infograf768 - comment - 2 May 2020

While testing/looking at this I found a potential problem with menu module edit in frontend:
We should normally not be able to modify the Published status if it contains the home page (have to check if the issue is only for multilingual sites) the problem being that one can have multiple menu modules using the same menutype.

avatar degobbis degobbis - change - 2 Jun 2020
Title
Use renderField frontend com_contig modules view
Use renderField frontend com_config modules view
avatar degobbis degobbis - edited - 2 Jun 2020

Add a Comment

Login with GitHub to post a comment