? Pending

User tests: Successful: Unsuccessful:

avatar coolcat-creations
coolcat-creations
26 Apr 2020

Summary of Changes

I put the background colour to the background definition and the text colour to the text definition, seems someone switched it by mistake :-)

I only applied/switched the right variables in the scss file :-)

Testing Instructions

Install patch
npm run build:css in terminal

Expected result

For example System Dashboard:
grafik

Actual result

For example System Dashboard:
grafik

Documentation Changes Required

no

avatar coolcat-creations coolcat-creations - open - 26 Apr 2020
avatar coolcat-creations coolcat-creations - change - 26 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2020
Category Administration Templates (admin)
avatar zero-24
zero-24 - comment - 26 Apr 2020

Can we double check that this is fine accessibility stuff. When that would be fine with accessibility. @chmst can you take a look here and check.

avatar Quy
Quy - comment - 26 Apr 2020

I have tested this item successfully on 1c4e11d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28812.

avatar Quy Quy - test_item - 26 Apr 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Apr 2020

I have tested this item successfully on 1c4e11d

tested everywhere I could think of where this is used.
The accessibility is fine


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28812.

avatar brianteeman brianteeman - test_item - 26 Apr 2020 - Tested successfully
avatar Quy Quy - change - 26 Apr 2020
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 26 Apr 2020

The accessibility is fine

awesome.

avatar Quy
Quy - comment - 26 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28812.

avatar zero-24 zero-24 - change - 26 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-26 12:43:18
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 26 Apr 2020
avatar zero-24 zero-24 - merge - 26 Apr 2020
avatar zero-24
zero-24 - comment - 26 Apr 2020

Merging

avatar coolcat-creations
coolcat-creations - comment - 26 Apr 2020

thank you all

Add a Comment

Login with GitHub to post a comment