There are currently 4 default module chromes in Joomla's core:
\layouts\chromes
What I'm proposing Joomla has a single, default chrome, without any styling.
So basically remove outline
, table
and html5
Chromes should derive from the template
Labels |
Added:
?
?
|
Status | New | ⇒ | Discussion |
What is the benefit?
First: This chromes by no means are "default" chromes. The default for any moduleposition is specified by the template. Those are "system" chromes.
Personally I don't see anything wrong with having some simple chromes shipped by the CMS which can be used by templates and users so not everyone needs to reinvent the wheel.
The "outline" one is actually used for the template position preview.
The "html5" is actively used by cassiopeia.
The table one seems like something you shouldn't use nowadays. That one could maybe removed with 4.0.
@brianteeman because the design should be dictated by the template. none
or table
are not used in core. So I ask myself, why would Joomla need to ship something it doesn't use in core? It's just more unecessary maintenance.
@Bakual Fair enough with the outline
chrome. html5
is only used by the banner. cardGrey
and default
are exactly the same other than the card-grey
class, so the default
chrome can be updated and used by the banner
@brianteeman because the design should be dictated by the template.
But it still is as the chrome is defined in the template. These are just generic chromes that a template can use to avoid reinventing the wheel. Or am I missing something?
The chrome is defined in the template, but the code belongs to the core. Two of them aren't used by core and one of them is unecessary.
because the design should be dictated by the template.
By this I was trying to say that chromes code should belong to the template, not the CMS
@C-Lodder I agree to what you say, but what if someone is using the existing chromes in the (old) template - is there already a doc how to migrate a J3 Template to a J4 Template? If we need to work anyway on the templates to make it work with J4 we could provide the chromes in the docs as a download so that the template person can include it if needed...
Honestly, the files really don't hurt anyone, it's not like it's much to maintain in there.
Two of them (none and outline) are still needed anyway.
One could discuss about table.
html5 is only used by the banner. cardGrey and default are exactly the same other than the card-grey class, so the default chrome can be updated and used by the banner
If default
is the same, why even use a custom one? Just use html5
instead. That's what I would do in my template so I don't have to maintain it myself. That's why the system chromes are there to begin with.
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-27 10:39:46 |
Closed_By | ⇒ | C-Lodder |
it's not like it's much to maintain in there.
html5
was still using BS2 until yesterday, but ok.
Closing
Related #20864?